- September 1, 2008
- 21,577
- 8,224
- Home Country
- New Zealand
Probably very little if any.How much review is needed for this?
http://git.io/wFxHngDiposing KNC library (probably only side effect) Fixed: [12:40] <MP1-GitBot> [MediaPortal-1] morpheusxx pushed 2 new commits to EXP-TVE3.5_MP_NET4: http://git.io/wFxHng
Probably very little if any.How much review is needed for this?
The use of cdecl in the previous code is a logical and functional error. The SDK/API which I have tells us that the functions are implemented/declared as stdcall in the DLL. Hence it is incorrect to use cdecl and correct to use stdcall. We see the proof in that the patch solves the problem. @morpheus_xx also found this problem when TVE 3.5 went to .NET 4:
https://forum.team-mediaportal.com/threads/planning-work-on-native-mp2-tvengine.110399/Diposing KNC library (probably only side effect) Fixed: [12:40] <MP1-GitBot> [MediaPortal-1] morpheusxx pushed 2 new commits to EXP-TVE3.5_MP_NET4: http://git.io/wFxHng
IMO this could be merged immediately...
Sorry, you shouldn't have to ask me to do that.Thanks!
Maybe you can also take care of the Jira entry.