Reply to thread

Message

<blockquote data-quote="MediaPortal-Bot" data-source="post: 539792" data-attributes="member: 48617"><a href="https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/tvplugin-audio-stream-not-selected-correctly-73722/" target="_blank">https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/tvplugin-audio-stream-not-selected-correctly-73722/</a> [<a href="https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/tvplugin-audio-stream-not-selected-correctly-73722/" target="_blank">^</a>]When you have setup Prefer-AC3 but NOT Prefer-AC3 over language and you have a stream with MPEG and AC3 both with correct language MP selects MPEG stream instead of AC3 stream. This is caused by a useless if condition which skips the scanning of additional streams after finding the first one.During introduction of unit tests I also found another bug:this scenario:1 dual mono audio track (dan/eng)lang. prefs: &quot;dan&quot;result: stereo. it should instead choose the left audio track as this matches the user lang. selectionnow the GetPreferedAudioStreamIndex method has 25+ unit tests to insure code/logic validity.<a href="http://mantis.team-mediaportal.com/view.php?id=2560" target="_blank">http://mantis.team-mediaportal.com/view.php?id=2560</a><a href="http://mantis.team-mediaportal.com/view.php?id=2560" target="_blank">Open the issue in Mantis...</a></blockquote>

[QUOTE="MediaPortal-Bot, post: 539792, member: 48617"] [URL]https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/tvplugin-audio-stream-not-selected-correctly-73722/[/URL] [[URL="https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/tvplugin-audio-stream-not-selected-correctly-73722/"]^[/URL]] When you have setup Prefer-AC3 but NOT Prefer-AC3 over language and you have a stream with MPEG and AC3 both with correct language MP selects MPEG stream instead of AC3 stream. This is caused by a useless if condition which skips the scanning of additional streams after finding the first one. During introduction of unit tests I also found another bug: this scenario: 1 dual mono audio track (dan/eng) lang. prefs: "dan" result: stereo. it should instead choose the left audio track as this matches the user lang. selection now the GetPreferedAudioStreamIndex method has 25+ unit tests to insure code/logic validity. [url]http://mantis.team-mediaportal.com/view.php?id=2560[/url] [url=http://mantis.team-mediaportal.com/view.php?id=2560]Open the issue in Mantis...[/url] [/QUOTE]

Verification