Reply to thread

Message

<blockquote data-quote="MediaPortal-Bot" data-source="post: 550570" data-attributes="member: 48617">1) There is now a file reference from the MusicMetadataExtractor to the DLL file &quot;..\..\..\..\Bin\MP-II-Client\bin\x86\Debug\Plugins\TagLibPlugin\TagLib.dll&quot;. Should be replaced by a reference to the TagLibPlugin itself.2) Media resource access was broken by this change:Index: D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs===================================================================--- D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs&nbsp; &nbsp; (revision 24525)+++ D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs&nbsp; &nbsp; (revision 24526)@@ -204,8 +204,7 @@&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; File tag;&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; try&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tag = File.Create(new MediaProviderFileAbstraction(mediaItemAccessor),-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Path.GetFileName(humanReadablePath), null, ReadStyle.Fast);+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; tag = File.Create(humanReadablePath);&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; }&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; catch (CorruptFileException)&nbsp; &nbsp; &nbsp; &nbsp;&nbsp; {The change is invalid and must be reverted. If the new TagLibPlugin doesn't support the file access via that file abstraction any more, it needs to be added.<a href="http://mantis.team-mediaportal.com/view.php?id=2592" target="_blank">http://mantis.team-mediaportal.com/view.php?id=2592</a><a href="http://mantis.team-mediaportal.com/view.php?id=2592" target="_blank">Open the issue in Mantis...</a></blockquote>

[QUOTE="MediaPortal-Bot, post: 550570, member: 48617"] 1) There is now a file reference from the MusicMetadataExtractor to the DLL file "..\..\..\..\Bin\MP-II-Client\bin\x86\Debug\Plugins\TagLibPlugin\TagLib.dll". Should be replaced by a reference to the TagLibPlugin itself. 2) Media resource access was broken by this change: Index: D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs =================================================================== --- D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24525) +++ D:/Projekte/Visual C#/MediaPortal/MP-Server/Source/Media/MetadataExtractors/MusicMetadataExtractor/MusicMetadataExtractor.cs (revision 24526) @@ -204,8 +204,7 @@ File tag; try { - tag = File.Create(new MediaProviderFileAbstraction(mediaItemAccessor), - Path.GetFileName(humanReadablePath), null, ReadStyle.Fast); + tag = File.Create(humanReadablePath); } catch (CorruptFileException) { The change is invalid and must be reverted. If the new TagLibPlugin doesn't support the file access via that file abstraction any more, it needs to be added. [url]http://mantis.team-mediaportal.com/view.php?id=2592[/url] [url=http://mantis.team-mediaportal.com/view.php?id=2592]Open the issue in Mantis...[/url] [/QUOTE]

Verification