Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 990088" data-attributes="member: 82144">Hello again&nbsp;Yes this is expected, as per my comment above...&nbsp;&nbsp;AIUI that setting is not a control of how many digits show.For example, if your channel numbers were all 2 digits long and the setting was 4, I wouldn't expect MP to pad the numbers out to 4 digits.(Does it do that? At work, so can't check...)What it is meant to be is an indicator for the zapping code so once you enter x number of digits MP will know to change channel without applying the zap delay.For example, changing to channel &quot;2&quot; with the setting value &quot;3&quot; is faster when you enter &quot;002&quot;.Make sense?&nbsp;&nbsp;&nbsp;Right, so it scanned as unknown on physical 7 but found the names on physical 35. Possibly this:<a href="http://mantis.team-mediaportal.com/view.php?id=3707" target="_blank">http://mantis.team-mediaportal.com/view.php?id=3707</a>&nbsp;&nbsp;&nbsp;Hmmm, okay.In binary terms those numbers are really close.65 = 0b1000001257 = 0b100000001&nbsp;Let me see... what does TsWriter do:<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/TsWriter/source/VirtualChannelTableParser.cpp#153" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/TsWriter/source/VirtualChannelTableParser.cpp#153</a>&nbsp;&nbsp;...with reference to ATSC A/65:<a href="http://www.atsc.org/cms/standards/a_65-2009.pdf" target="_blank">http://www.atsc.org/cms/standards/a_65-2009.pdf</a>(page 32 table 6.4)&nbsp;And there we see a bug. Code is:[code]&nbsp; int major_channel =((buf[start ]&amp;0xf)&lt;&lt;8) + (buf[start+1]&gt;&gt;2);&nbsp; int minor_channel =((buf[start+1]&amp;0x3)&lt;&lt;8) + buf[start+2];[/code]&nbsp;Code should be:[code=c#]&nbsp; int major_channel =((buf[start ]&amp;0xf)&lt;&lt;6) + (buf[start+1]&gt;&gt;2);&nbsp; int minor_channel =((buf[start+1]&amp;0x3)&lt;&lt;8) + buf[start+2];[/code][edit: bolding doesn't work with code! Note the 6 instead of the 8 in the first statement.]&nbsp;And this bug would have precisely the effect that you described. It only affects major channel numbers greater than 63.&nbsp;mm</blockquote>

[QUOTE="mm1352000, post: 990088, member: 82144"] Hello again Yes this is expected, as per my comment above... AIUI that setting is not a control of how many digits show. For example, if your channel numbers were all 2 digits long and the setting was 4, I wouldn't expect MP to pad the numbers out to 4 digits. (Does it do that? At work, so can't check...) What it is meant to be is an indicator for the zapping code so once you enter x number of digits MP will know to change channel without applying the zap delay. For example, changing to channel "2" with the setting value "3" is faster when you enter "002". Make sense? Right, so it scanned as unknown on physical 7 but found the names on physical 35. Possibly this: [url]http://mantis.team-mediaportal.com/view.php?id=3707[/url] Hmmm, okay. In binary terms those numbers are really close. 65 = 0b1000001 257 = 0b100000001 Let me see... what does TsWriter do: [url]https://github.com/MediaPortal/MediaPortal-1/blob/master/DirectShowFilters/TsWriter/source/VirtualChannelTableParser.cpp#153[/url] ...with reference to ATSC A/65: [url]http://www.atsc.org/cms/standards/a_65-2009.pdf[/url] (page 32 table 6.4) And there we see a bug. Code is: [code] int major_channel =((buf[start ]&0xf)<<8) + (buf[start+1]>>2); int minor_channel =((buf[start+1]&0x3)<<8) + buf[start+2];[/code] Code should be: [code=c#] int major_channel =((buf[start ]&0xf)<<6) + (buf[start+1]>>2); int minor_channel =((buf[start+1]&0x3)<<8) + buf[start+2];[/code] [edit: bolding doesn't work with code! Note the 6 instead of the 8 in the first statement.] And this bug would have precisely the effect that you described. It only affects major channel numbers greater than 63. mm [/QUOTE]

Verification