Reply to thread

Message

<blockquote data-quote="Sebastiii" data-source="post: 1240864" data-attributes="member: 60104">Hey <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />I've maybe another bug, i was trying to look at [USER=68833]@ajs[/USER] issue :[code][2018-03-02 21:33:31,351] [Error&nbsp; ] [CheckConnection] [ERROR] - MediaPortal: Unhandled exception occured[2018-03-02 21:33:31,371] [Log&nbsp; &nbsp; ] [CheckConnection] [ERROR] - Exception: System.NullReferenceException: Ð¡ÑÑ‹Ð»ÐºÐ° Ð½Ð° Ð¾Ð±ÑŠÐµÐºÑ‚ Ð½Ðµ ÑƒÐºÐ°Ð·Ñ‹Ð²Ð°ÐµÑ‚ Ð½Ð° ÑÐºÐ·ÐµÐ¼Ð¿Ð»ÑÑ€ Ð¾Ð±ÑŠÐµÐºÑ‚Ð°.&nbsp;&nbsp; Ð² System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)&nbsp;&nbsp; Ð² System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)&nbsp;&nbsp; Ð² TraktPlugin.GUI.GUIUtils.ShowNotifyDialog(String heading, String text, String image, String buttonText, Int32 timeout)&nbsp;&nbsp; Ð² TraktPlugin.TraktPlugin.&lt;&gt;c.&lt;GUIWindowManager_OnActivateWindow&gt;b__34_0()&nbsp;&nbsp; Ð² System.Threading.ThreadHelper.ThreadStart_Context(Object state)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)&nbsp;&nbsp; Ð² System.Threading.ThreadHelper.ThreadStart()&nbsp; Message: Ð¡ÑÑ‹Ð»ÐºÐ° Ð½Ð° Ð¾Ð±ÑŠÐµÐºÑ‚ Ð½Ðµ ÑƒÐºÐ°Ð·Ñ‹Ð²Ð°ÐµÑ‚ Ð½Ð° ÑÐºÐ·ÐµÐ¼Ð¿Ð»ÑÑ€ Ð¾Ð±ÑŠÐµÐºÑ‚Ð°.&nbsp; Site&nbsp;&nbsp; : System.Object MarshaledInvoke(System.Windows.Forms.Control, System.Delegate, System.Object[], Boolean)&nbsp; Source : System.Windows.Forms&nbsp; Stack Trace:&nbsp; &nbsp;&nbsp; Ð² System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)&nbsp;&nbsp; Ð² System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)&nbsp;&nbsp; Ð² TraktPlugin.GUI.GUIUtils.ShowNotifyDialog(String heading, String text, String image, String buttonText, Int32 timeout)&nbsp;&nbsp; Ð² TraktPlugin.TraktPlugin.&lt;&gt;c.&lt;GUIWindowManager_OnActivateWindow&gt;b__34_0()&nbsp;&nbsp; Ð² System.Threading.ThreadHelper.ThreadStart_Context(Object state)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)&nbsp;&nbsp; Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)&nbsp;&nbsp; Ð² System.Threading.ThreadHelper.ThreadStart()[/code]And i have run into MP crash :[code]Application: MediaPortal.exeFramework Version: v4.0.30319Description: The process was terminated due to an unhandled exception.Exception Info: System.IO.FileNotFoundExceptionServer stack trace:&nbsp;&nbsp; at TraktAPI.Extensions.JSONExtensions.FromJSONDictionary[T](String json)&nbsp;&nbsp; at TraktAPI.Extensions.DateTimeExtensions.OlsenToWindowsTimezone(String olsenTimezone)&nbsp;&nbsp; at TraktPlugin.GUI.GUICommon.SetShowProperties(TraktShowSummary show)&nbsp;&nbsp; at TraktPlugin.TraktDashboard.OnTrendingShowSelected(GUIListItem item, GUIControl parent)&nbsp;&nbsp; at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]&amp; outArgs)&nbsp;&nbsp; at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink)&nbsp;&nbsp; at System.Runtime.Remoting.Proxies.RealProxy.EndInvokeHelper(System.Runtime.Remoting.Messaging.Message, Boolean)&nbsp;&nbsp; at System.Runtime.Remoting.Proxies.RemotingProxy.Invoke(System.Object, System.Runtime.Remoting.Proxies.MessageData ByRef)&nbsp;&nbsp; at MediaPortal.GUI.Library.GUIListItem+ItemSelectedHandler.EndInvoke(System.IAsyncResult)&nbsp;&nbsp; at MediaPortal.GUI.Library.GUIListItem.itemSelectedCallback(System.IAsyncResult)&nbsp;&nbsp; at System.Runtime.Remoting.Messaging.AsyncResult.SyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage)&nbsp;&nbsp; at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage, System.Runtime.Remoting.Messaging.IMessageSink)&nbsp;&nbsp; at System.Runtime.Remoting.Proxies.AgileAsyncWorkerItem.ThreadPoolCallBack(System.Object)&nbsp;&nbsp; at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(System.Object)&nbsp;&nbsp; at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)&nbsp;&nbsp; at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)&nbsp;&nbsp; at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()&nbsp;&nbsp; at System.Threading.ThreadPoolWorkQueue.Dispatch()&nbsp;&nbsp; at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()[/code]So looked the code and add a try catch here : [code=csharp]/// &lt;summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// Returns the corresponding Olsen timezone e.g. 'Atlantic/Canary' into a Windows timezone e.g. 'GMT Standard Time'&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;/summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; public static string OlsenToWindowsTimezone(this string olsenTimezone)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (olsenTimezone == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (_timezoneMappings == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _timezoneMappings = Resources.OlsenToWindows.FromJSONDictionary&lt;Dictionary&lt;string, string&gt;&gt;();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string windowsTimezone;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _timezoneMappings.TryGetValue(olsenTimezone, out windowsTimezone);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return windowsTimezone;&nbsp; &nbsp; &nbsp; &nbsp; }[/code]This try / catch seems to do the work <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />I've reproduced it but starting MP with load last plugin (here Trakt) and start to navigate <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" /> and boom <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />[ATTACH=full]196615[/ATTACH]I have also noted a possible bull reference exception here &quot;DateTimeFormatInfo.CurrentInfo' (just after above code) for <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />[code=csharp]public static string ToLocalisedDayOfWeek(this DateTime date)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return DateTimeFormatInfo.CurrentInfo.GetDayName(date.DayOfWeek);&nbsp; &nbsp; &nbsp; &nbsp; }[/code]</blockquote>

[QUOTE="Sebastiii, post: 1240864, member: 60104"] Hey :) I've maybe another bug, i was trying to look at [USER=68833]@ajs[/USER] issue : [code][2018-03-02 21:33:31,351] [Error ] [CheckConnection] [ERROR] - MediaPortal: Unhandled exception occured [2018-03-02 21:33:31,371] [Log ] [CheckConnection] [ERROR] - Exception: System.NullReferenceException: Ð¡ÑÑ‹Ð»ÐºÐ° Ð½Ð° Ð¾Ð±ÑŠÐµÐºÑ‚ Ð½Ðµ ÑƒÐºÐ°Ð·Ñ‹Ð²Ð°ÐµÑ‚ Ð½Ð° ÑÐºÐ·ÐµÐ¼Ð¿Ð»ÑÑ€ Ð¾Ð±ÑŠÐµÐºÑ‚Ð°. Ð² System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous) Ð² System.Windows.Forms.Control.Invoke(Delegate method, Object[] args) Ð² TraktPlugin.GUI.GUIUtils.ShowNotifyDialog(String heading, String text, String image, String buttonText, Int32 timeout) Ð² TraktPlugin.TraktPlugin.<>c.<GUIWindowManager_OnActivateWindow>b__34_0() Ð² System.Threading.ThreadHelper.ThreadStart_Context(Object state) Ð² System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) Ð² System.Threading.ThreadHelper.ThreadStart() Message: Ð¡ÑÑ‹Ð»ÐºÐ° Ð½Ð° Ð¾Ð±ÑŠÐµÐºÑ‚ Ð½Ðµ ÑƒÐºÐ°Ð·Ñ‹Ð²Ð°ÐµÑ‚ Ð½Ð° ÑÐºÐ·ÐµÐ¼Ð¿Ð»ÑÑ€ Ð¾Ð±ÑŠÐµÐºÑ‚Ð°. Site : System.Object MarshaledInvoke(System.Windows.Forms.Control, System.Delegate, System.Object[], Boolean) Source : System.Windows.Forms Stack Trace: Ð² System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous) Ð² System.Windows.Forms.Control.Invoke(Delegate method, Object[] args) Ð² TraktPlugin.GUI.GUIUtils.ShowNotifyDialog(String heading, String text, String image, String buttonText, Int32 timeout) Ð² TraktPlugin.TraktPlugin.<>c.<GUIWindowManager_OnActivateWindow>b__34_0() Ð² System.Threading.ThreadHelper.ThreadStart_Context(Object state) Ð² System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) Ð² System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) Ð² System.Threading.ThreadHelper.ThreadStart() [/code] And i have run into MP crash : [code]Application: MediaPortal.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.IO.FileNotFoundException Server stack trace: at TraktAPI.Extensions.JSONExtensions.FromJSONDictionary[T](String json) at TraktAPI.Extensions.DateTimeExtensions.OlsenToWindowsTimezone(String olsenTimezone) at TraktPlugin.GUI.GUICommon.SetShowProperties(TraktShowSummary show) at TraktPlugin.TraktDashboard.OnTrendingShowSelected(GUIListItem item, GUIControl parent) at System.Runtime.Remoting.Messaging.StackBuilderSink._PrivateProcessMessage(IntPtr md, Object[] args, Object server, Object[]& outArgs) at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(IMessage msg, IMessageSink replySink) at System.Runtime.Remoting.Proxies.RealProxy.EndInvokeHelper(System.Runtime.Remoting.Messaging.Message, Boolean) at System.Runtime.Remoting.Proxies.RemotingProxy.Invoke(System.Object, System.Runtime.Remoting.Proxies.MessageData ByRef) at MediaPortal.GUI.Library.GUIListItem+ItemSelectedHandler.EndInvoke(System.IAsyncResult) at MediaPortal.GUI.Library.GUIListItem.itemSelectedCallback(System.IAsyncResult) at System.Runtime.Remoting.Messaging.AsyncResult.SyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage) at System.Runtime.Remoting.Messaging.StackBuilderSink.AsyncProcessMessage(System.Runtime.Remoting.Messaging.IMessage, System.Runtime.Remoting.Messaging.IMessageSink) at System.Runtime.Remoting.Proxies.AgileAsyncWorkerItem.ThreadPoolCallBack(System.Object) at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch() at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback() [/code] So looked the code and add a try catch here : [code=csharp]/// <summary> /// Returns the corresponding Olsen timezone e.g. 'Atlantic/Canary' into a Windows timezone e.g. 'GMT Standard Time' /// </summary> public static string OlsenToWindowsTimezone(this string olsenTimezone) { if (olsenTimezone == null) return null; if (_timezoneMappings == null) { try { _timezoneMappings = Resources.OlsenToWindows.FromJSONDictionary<Dictionary<string, string>>(); } catch (Exception) { return null; } } string windowsTimezone; _timezoneMappings.TryGetValue(olsenTimezone, out windowsTimezone); return windowsTimezone; }[/code] This try / catch seems to do the work :P I've reproduced it but starting MP with load last plugin (here Trakt) and start to navigate :P and boom :) [ATTACH=full]196615[/ATTACH] I have also noted a possible bull reference exception here "DateTimeFormatInfo.CurrentInfo' (just after above code) for :P [code=csharp]public static string ToLocalisedDayOfWeek(this DateTime date) { return DateTimeFormatInfo.CurrentInfo.GetDayName(date.DayOfWeek); }[/code] [/QUOTE]

Verification