[Pending] Added process priority setting to Comskip Launcher plugin. (2 Viewers)

[cwchapma]

I've submitted a pull request for a change to the comskip launcher plugin to allow/default to running comskip with a lower than normal thread priority. It made a huge difference to my mediaportal setup and I would love to share

https://github.com/MediaPortal/MediaPortal-1/pull/23

Comments appreciated,
Clint

 

[cwchapma]

Still looking for someone to take a look at this pull request. Anybody able to take a look at it?

https://github.com/MediaPortal/MediaPortal-1/pull/23

Thanks,
Clint

 

[regeszter]

Hi,

the TVE3 is in code freeze state so we can't do any changes until TVE3.5 is released.

 

[cwchapma]

I've tried to find info on TVE 3.5 and haven't had any luck. Is there info somewhere on what the features of 3.5 are or when it is expected to be released?

Thanks for letting me know.

Clint

 

[Sebastiii]

If i'm not wrong the code will be easy to port to TVE35 so maybe we should include it for TVE3 (if all seems in good way TVE3 will be the last with 1.6 Release, i mean code freeze and we can focus on TVE35).

@mm1352000 @elliottmc ?

Ps : Like we have a big work to adapt current TVE35 against actual TVE3, i think that patch will be a very little change

 

[elliottmc]

If i'm not wrong the code will be easy to port to TVE35 so maybe we should include it for TVE3 (if all seems in good way TVE3 will be the last with 1.6 Release, i mean code freeze and we can focus on TVE35).

@mm1352000 @elliottmc ?

Ps : Like we have a big work to adapt current TVE35 against actual TVE3, i think that patch will be a very little change

But every additional change adds to the work. This really is down to mm1352000.

 

[Holzi]

Too bad this patch was created 6 months ago and nothing happened..
I created a Jira issue: https://issues.team-mediaportal.com/browse/MP1-4265 and could help with Docs if needed.

 

[mm1352000]

If i'm not wrong the code will be easy to port to TVE35...

The tricky stuff will be the stuff that involves TvBusinessLayer and settings, because TvBusinessLayer no longer exists.

...so maybe we should include it for TVE3 (if all seems in good way TVE3 will be the last with 1.6 Release, i mean code freeze and we can focus on TVE35).

I don't want to be the bad guy but we need to draw the line somewhere. Personally I don't use comskip and I don't know that area of the code. As with MySQL, I'm not going to stop you putting it into TVE 3 as long as you are willing to merge it to TVE 3.5 (assuming the patch is accepted).

 

[markus_g]

I've submitted a pull request for a change to the comskip launcher plugin to allow/default to running comskip with a lower than normal thread priority. It made a huge difference to my mediaportal setup and I would love to share

https://github.com/MediaPortal/MediaPortal-1/pull/23

Comments appreciated,
Clint

Hi, I have just started using Comskip and have found this is really needed. Tsreader on my setup doesn't seem to cope very well when Comskip is running.
Regards,

Markus.

 

[mbuzina]

Are TV Server Plugins also frozen? I thought we have a plugin structure to avoid such issues...

Unless TVE 3.5 contains a different ComSkip Launcher it should not be a big issue, shouldn't it?