[Approved] Added proper horizontal scrollbar to filmstrip (1 Viewer)

[pilehave]

Once again I updated the patch, see first post.

 

[elliottmc]

I am trying to get the team to look at these patches. Do you have access to the team internal forums?

If so, perhaps you can post there as well.

Best wishes,

Mark

 

[pilehave]

I am trying to get the team to look at these patches. Do you have access to the team internal forums?

If so, perhaps you can post there as well.

Best wishes,

Mark

Nope, no access. Would be nice to have at least read-access

 

[ajp8164]

Spirited dialog! ;-)

Just so you know my thoughts (does anyone care? ;-) ... I added the local control option for the horizontal scrollbar (thereby needing the mouse support bypass) because it's poor UI design to not have an indication of how big the coverflow set is - while you're scrolling it is very good feedback to know where you are in the set. Alternatively you could argue that using a card count (x of y) but since the coverflow control is overwhelmingly graphical in nature it makes the best sense to also provide a good graphical representation of where you are in the card set. Actually, this is the reason that the first implementation did not have the ability to scroll with the mouse (there was no hit test for the mouse). I've never seen a coverflow on any device not have a scrollbar (not saying there aren't example, but they are likely few).

For this reason, I think it is reasonable to allow the filmstrip to have the same logic. I recommend putting back the mouse support bypass checks.

Bottom line is that having the mouse support bypass checks is an extra feature. The skin designer has the flexibility to choose whether or not they should respect the configuration settings or override and use the local control setting. IMHO, most skin designers will choose to display the scrollbar regardless of the configuration options.

 

[ajp8164]

Implemented in SVN - please see mantis 3420.

 

[catavolt]

AW: Added proper horizontal scrollbar to filmstrip

Is the skin syntax the same as in coverflow?
I added:

<scrollbarBackground>bar_hor.png</scrollbarBackground>
<scrollbarLeft>mouse_left_horizontal.png</scrollbarLeft>
<scrollbarRight>mouse_right_horizontal.png</scrollbarRight>
<scrollbarYOff>460</scrollbarYOff>
<showScrollbar>yes</showScrollbar>

to filmstrip and nothing is shown...

 

[pilehave]

Re: AW: Added proper horizontal scrollbar to filmstrip

Is the skin syntax the same as in coverflow?
I added:

<scrollbarBackground>bar_hor.png</scrollbarBackground>
<scrollbarLeft>mouse_left_horizontal.png</scrollbarLeft>
<scrollbarRight>mouse_right_horizontal.png</scrollbarRight>
<scrollbarYOff>460</scrollbarYOff>
<showScrollbar>yes</showScrollbar>

to filmstrip and nothing is shown...

No, they have (for some reason) always been a bit different than list/thumbview, so to not break backwards compatibility, I kept them as they were:

<scrollbarWidth>536</scrollbarWidth>
<scrollbarHeight>20</scrollbarHeight>
<scrollbarbg>bar_hor.png</scrollbarbg>
<scrollbartop>mouse_left_horizontal.png</scrollbartop>
<scrollbarbottom>mouse_right_horizontal.png</scrollbarbottom>
<scrollbarXOff>0</scrollbarXOff>
<scrollbarYOff>460</scrollbarYOff>
<showScrollbar>yes</showScrollbar>

I will update the Wiki later tonight!

 

[ajp8164]

Guys -

I can certainly appreciate not breaking skins by trying to be backward compatible but in this case the the top/bottom skin elements are just named wrong. The reason that the thumbnail panel uses <scrollbarTop> and <scrollbarBottom> is that the thumbnail panel scrolls vertically and so uses a vertical scrollbar. Both cover flow and filmstrip use a horizontal scrollbar.

I have committed changes to bring the implementation in line with Cover Flow. Here are the skin elements to do with scrollbar in filmstrip.

<scrollbarBackground>
<scrollbarLeft>
<scrollbarRight>
<scrollbarYOff>
<scrollbarWidth>
<scrollbarHeight>
<showScrollbar> - I added this back, again for completeness and  to match cover flow

 

[catavolt]

AW: Added proper horizontal scrollbar to filmstrip

pilehave, Now it works like a charm! Nice work!
EDIT: Ahh, Andy has changed it again - will try that than instead with SVN 27537...

 

[pilehave]

Guys -

I can certainly appreciate not breaking skins by trying to be backward compatible but in this case the the top/bottom skin elements are just named wrong. The reason that the thumbnail panel uses <scrollbarTop> and <scrollbarBottom> is that the thumbnail panel scrolls vertically and so uses a vertical scrollbar. Both cover flow and filmstrip use a horizontal scrollbar.

I have committed changes to bring the implementation in line with Cover Flow. Here are the skin elements to do with scrollbar in filmstrip.

<scrollbarBackground>
<scrollbarLeft>
<scrollbarRight>
<scrollbarYOff>
<scrollbarWidth>
<scrollbarHeight>
<showScrollbar> - I added this back, again for completeness and  to match cover flow

Thanks. In the old Wiki I had also added a note about the naming of the scrollbar in filmstrip. And since B3W by default has no scrollbar in filmstrip, I guess it is OK