[Rejected] After Build 24324 , Playing recorded TS, close MP at the end of the file (1 Viewer)

[iosub]

Hi..

After this revision, If you play a TVRecorded show and wait until it finish MP closes without any message.

Revision: 24324
Author: hwahrmann
Date: 21:21:23, miércoles, 02 de diciembre de 2009
Message:
Fix #2398: Hitting "PLay" to return to normal speed after a FF/REW in Music, restarted Playback
----
Modified : /trunk/mediaportal/xbmc/MediaPortal.cs
Modified : /trunk/mediaportal/Core/Player/g_player.cs
Modified : /trunk/mediaportal/WindowPlugins/GUIMusic/GUIMusicFiles.cs
Modified : /trunk/mediaportal/WindowPlugins/GUIMusic/GUIMusicGenres.cs
=======================================================

Steps to reproduce

1.- Start a Recorded show.
2.- Move Just before the end (30sec) of the show and let MP play until the End
3.- MP close

I attach the logs where you can see the error.log

I have found that the problem is on file g_player.cs (Build 24324)
line 585 _player.Speed = 1; if I comment the line Mp does not close

Hope this helps!

Iosu

Fixed on Can any of the admins close this?

Author: mr_hipp
Date: 2009-12-17 18:57:03 +0100 (Thu, 17 Dec 2009) New Revision: 24484

Modified:
trunk/mediaportal/Core/Player/g_player.cs
Log:
Causes crash in TS reader

Modified: trunk/mediaportal/Core/Player/g_player.cs
===================================================================
--- trunk/mediaportal/Core/Player/g_player.cs 2009-12-17 17:28:29 UTC (rev 24483)
+++ trunk/mediaportal/Core/Player/g_player.cs 2009-12-17 17:57:03 UTC (rev 24484)
@@ -582,7 +582,8 @@
return;
}

- _player.Speed = 1;
+ // Fix me - causes crash in BaseTSReaderPlayer.cs
+ //_player.Speed = 1;
GUIGraphicsContext.ShowBackground = true;
if (!keepTimeShifting && !keepExclusiveModeOn)
{

 

[-Manfred-]

Have a look at fixed BaseTSReaderPlayer in SVN and test when speed setting is in place. Unfortunately MrHipp was a bit too fast with his commit

 

[iosub]

I will test

Anyway... The idea of opensource is that we all can help to make a better product right?


Thanks!
Iosu

 

[-Manfred-]

Yes, helping out is great - thx. This BaseTSReaderPlayer way we nailed the root cause and will prevent other possible occasions.

I will reject this as the root cause is now fixed.

 

[hwahrmann]

ah didn't have a look in this thread before i applied a fix. i moved the setting of the speed into Music Player, so the problem wouldn't have happened anymore.
But thanks again Manfred for applying the fix.