Reply to thread

Message

<blockquote data-quote="Guzzi" data-source="post: 604343" data-attributes="member: 55213">AW: AMC Updater v0.8.0 Now Available!rechecked an old bug, that is still in:5.) Audiobitrate and Videobitrate are incorrectly written to DB:As mentioned and confirmed by Orionhall, the audiobitrate retrieved from mediainfo.dll is incorrectly calculated; it is divided by 1024, but should be divided by 1000 to write correct values in DB.See also <a href="https://forum.team-mediaportal.com/my-films-164/amc-updater-v0-8-0-now-available-46463/index19.html#post382025" target="_blank">https://forum.team-mediaportal.com/my-films-164/amc-updater-v0-8-0-now-available-46463/index19.html#post382025</a>How to reproduce:Import a movie (or use &quot;test-tab&quot;) with e.g. AC3 audio - it shows 438 kbps - instead 448. Same error for all other bitrates.Checked the latest Sources I could find (I think 0.7.x or 0.8.x) it's the following lines in Module1.vb:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Case &quot;videobitrate&quot; 'divide by 1024&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TempString = MI.Get_(StreamKind.Visual, 0, &quot;Bitrate&quot;)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Integer.TryParse(TempString, TempInteger)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; If TempInteger &lt;&gt; 0 Then&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ReturnValue = CInt(TempInteger / 1024).ToString&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Case &quot;audiobitrate&quot; 'divide&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; TempString = MI.Get_(StreamKind.Audio, 0, &quot;Bitrate&quot;)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Integer.TryParse(TempString, TempInteger)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; If TempInteger &lt;&gt; 0 Then&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ReturnValue = CInt((TempInteger / 1024)).ToStringSo it's only changing those 2 lines to &nbsp; &nbsp;&nbsp; &quot;ReturnValue = CInt(TempInteger / 1000).ToString&quot;to fix that <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />GuzziPS: Can you post the latest sources from AMCupdater (and MyFilms) somewhere? (Or check then in to Sourcefourge MP-Plugins) ... the last available Sources are very old...</blockquote>

[QUOTE="Guzzi, post: 604343, member: 55213"] [b]AW: AMC Updater v0.8.0 Now Available![/b] rechecked an old bug, that is still in: 5.) Audiobitrate and Videobitrate are incorrectly written to DB: As mentioned and confirmed by Orionhall, the audiobitrate retrieved from mediainfo.dll is incorrectly calculated; it is divided by 1024, but should be divided by 1000 to write correct values in DB. See also [url]https://forum.team-mediaportal.com/my-films-164/amc-updater-v0-8-0-now-available-46463/index19.html#post382025[/url] How to reproduce: Import a movie (or use "test-tab") with e.g. AC3 audio - it shows 438 kbps - instead 448. Same error for all other bitrates. Checked the latest Sources I could find (I think 0.7.x or 0.8.x) it's the following lines in Module1.vb: Case "videobitrate" 'divide by 1024 Try TempString = MI.Get_(StreamKind.Visual, 0, "Bitrate") Integer.TryParse(TempString, TempInteger) If TempInteger <> 0 Then ReturnValue = CInt(TempInteger / 1024).ToString Case "audiobitrate" 'divide Try TempString = MI.Get_(StreamKind.Audio, 0, "Bitrate") Integer.TryParse(TempString, TempInteger) If TempInteger <> 0 Then ReturnValue = CInt((TempInteger / 1024)).ToString So it's only changing those 2 lines to "ReturnValue = CInt(TempInteger / 1000).ToString" to fix that :) Guzzi PS: Can you post the latest sources from AMCupdater (and MyFilms) somewhere? (Or check then in to Sourcefourge MP-Plugins) ... the last available Sources are very old... [/QUOTE]

Verification