Another change to MyRSS (1 Viewer)

AndyQ

Portal Member
May 27, 2005
25
0
I've submitted a patch (1261272) to change the way the available feeds are displayed. Now uses a list control rather than a select button.

I've changed all the 4 skins and also fixed a bug in the GUITextScrollUpControl where the scrolloffset doesn't get reset when you set the text (resulting in the text disappearing off the screen initially).

Andy
 

waeberd

Portal Pro
August 16, 2004
314
1
Fribourg (CH)
Andy,

First, thanks a lot for your nice work, very appreciated!

fixed a bug in the GUITextScrollUpControl

committed & thanks for fixing "my" bug :)

Regarding the myNews plugin:

Nice work and it's better than before, but I have a suggestion:

How about having a FEED-button displaying the currently selected feed...
... and if the button is clicked, a popup-dialog appears showing all available feeds in a modal select dialog? Exactly the same way we select a Music-View / Program-View ?

This would look nicer to me and would be more consistent!
What do you think?

Thanks again,

Daniel
 

mzemina

Retired Team Member
  • Premium Supporter
  • February 23, 2005
    2,065
    14
    Tulsa, OK
    Home Country
    United States of America United States of America
    If you go to WritTorrent and scroll 2/3 (or more) down on this web page you will find "xml2xlobby - XSL Transformations for Xlobby provides syndicated media channels" It seems this fellow has some open source available and maybe able to put to some good use? Looks like he has already created a plugin for XLobby.

    Mike
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    waeberd said:
    How about having a FEED-button displaying the currently selected feed...
    ... and if the button is clicked, a popup-dialog appears showing all available feeds in a modal select dialog? Exactly the same way we select a Music-View / Program-View ?

    Thats not a bad idea at all - I'll take a look at that.

    Andy
     

    waeberd

    Portal Pro
    August 16, 2004
    314
    1
    Fribourg (CH)
    AndyQ said:
    waeberd said:
    How about having a FEED-button displaying the currently selected feed...
    ... and if the button is clicked, a popup-dialog appears showing all available feeds in a modal select dialog? Exactly the same way we select a Music-View / Program-View ?

    Thats not a bad idea at all - I'll take a look at that.


    Andy,

    a good place to peek at is GUIMusicBaseWindow.cs, "OnShowViews"
    and to use the GUIDialogMenu dialog to select the feed.

    I'm sure the screen would look less busy! Do you want me to do that or give it a try?

    Hope you don't mind about that "different" idea :)

    Thanks,

    Daniel





    Code:
    protected void OnShowViews()
    {
    	GUIDialogMenu dlg=(GUIDialogMenu)GUIWindowManager.GetWindow((int)GUIWindow.Window.WINDOW_DIALOG_MENU);
    	if (dlg==null) return;
    	dlg.Reset();
    	dlg.SetHeading(924); // menu
    	dlg.Add ( GUILocalizeStrings.Get(134));//songs
    	foreach (ViewDefinition view in handler.Views)
    	{
    		dlg.Add( view.Name); //play
    	}
    	dlg.DoModal( GetID);
    
    BLABLABLA
    
    	if (dlg.SelectedLabel==-1) return;
    }
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    OK, Submitted patch: 1263524

    Pressing the Select Feed button now brings up a dialog box (same as My Music select view) where the feed can be selected.

    A progress dialog is also displayed (for min of 1 sec to avoid dialog flicker) when retrieving the feed so that the user is aware that something is happening.

    Also, fixed a bug in GUIDialogText where if you scroll down a few pages, exist the dialog and bring it up again, the scroll buttons say you are on page 1 but the displayed text isn't the first page.

    Patch contains all 4 myrss.xml skins, GUIialogText.cs & GUIRSSFeed.cs.

    Andy
     

    civikdude

    Portal Pro
    March 17, 2005
    110
    0
    U.S.A.
    waeberd said:
    GREAT! All in cvs, thank you for your nice work!

    Is this the same "CVS" as is found on http://www.myshare.de/mediaportal-cvs-download.php, or somewhere different? I downloaded the 21-06 file from today and did not see this included as one of the plugins, so I wasn't sure if there was some other place I should look. I would love to know since this plugin sounds great!
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    I've just checked the latest (mediaportal-cvs-08-19-2005--23-49.rar) and the MyNews chanes are in that.

    Andy
     

    Users who are viewing this thread

    Top Bottom