Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1142706" data-attributes="member: 82144">I think it looks mostly okay.Sometimes you could use -- or ++ instead of:[code]GUIGraphicsContext.DeviceAudioConnected = GUIGraphicsContext.DeviceAudioConnected + 1;[/code]Just a bit shorter. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Also, a small tweak:[code]public static int DeviceAudioConnected{&nbsp; get { return _deviceAudioConnected; }&nbsp; set&nbsp; {&nbsp; &nbsp; if (value &gt; _deviceAudioConnected)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; _deviceAudioConnected = value;&nbsp; &nbsp; &nbsp; Log.Debug(&quot;GraphicContext: device audio connected - Count {0}&quot;, _deviceAudioConnected);&nbsp; &nbsp; }&nbsp; &nbsp; else if (value &lt; _deviceAudioConnected)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; _deviceAudioConnected = value &lt; 0 ? 0 : value;&nbsp; &nbsp; &nbsp; Log.Debug(&quot;GraphicContext: device audio removed - Count {0}&quot;, _deviceAudioConnected);&nbsp; &nbsp; }&nbsp; }}[/code]This fixes:<ul>
<li data-xf-list-type="ul">don't log if value is not changing (should not happen, but good to handle all possibilities)</li>
<li data-xf-list-type="ul">log if device is removed, even if _deviceAudioConnected is 0</li>
</ul>It seems the main thing is to finish DetectedFirstAudioStart?</blockquote>

[QUOTE="mm1352000, post: 1142706, member: 82144"] I think it looks mostly okay. Sometimes you could use -- or ++ instead of: [code]GUIGraphicsContext.DeviceAudioConnected = GUIGraphicsContext.DeviceAudioConnected + 1;[/code] Just a bit shorter. :) Also, a small tweak: [code]public static int DeviceAudioConnected { get { return _deviceAudioConnected; } set { if (value > _deviceAudioConnected) { _deviceAudioConnected = value; Log.Debug("GraphicContext: device audio connected - Count {0}", _deviceAudioConnected); } else if (value < _deviceAudioConnected) { _deviceAudioConnected = value < 0 ? 0 : value; Log.Debug("GraphicContext: device audio removed - Count {0}", _deviceAudioConnected); } } }[/code] This fixes: [LIST] [*]don't log if value is not changing (should not happen, but good to handle all possibilities) [*]log if device is removed, even if _deviceAudioConnected is 0 [/LIST] It seems the main thing is to finish DetectedFirstAudioStart? [/QUOTE]

Verification