Reply to thread

Message

<blockquote data-quote="davidf" data-source="post: 571781" data-attributes="member: 19484">I noticed that there is an open Mantis item opened against picking a rate which is not valid. I had a slight issue where my 1:1 Pixel mapping was only available at 60Hz and as I live in a PAL region I had startred to modify the code to allow the resolution to change to get the desired refresh rate (I think refresh rate is more important than perfect pixel mapping) and the code I have started may solve the issue for Sythe42.&nbsp; This is the code I added to Monitor.cs:[code]&nbsp; &nbsp; &nbsp; &nbsp; //assume total pixels count will be a good match&nbsp; &nbsp; &nbsp; &nbsp; static int MatchAlgorithm(uint Xpels, uint yPels)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return (int)Xpels * (int)yPels;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; static DEVMODE_Display GetClosestRefreshRate(Monitor.Win32.DISPLAY_DEVICE displayDevice, uint xPrefered, uint yPrefered, uint refreshRate)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; List&lt;Monitor.Win32.DEVMODE_Display&gt; validModes = new List&lt;DEVMODE_Display&gt;();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.DEVMODE_Display ret = null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; uint bpp=32;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.DEVMODE_Display display = new DEVMODE_Display();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (0!=Monitor.Win32.EnumDisplaySettingsEx(displayDevice.DeviceName,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.EnumDisplaySettings_EnumMode.ENUM_CURRENT_SETTINGS,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; display,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 0))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bpp = display.dmBitsPerPel;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int currMode = 0;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; while (0!=Monitor.Win32.EnumDisplaySettingsEx(displayDevice.DeviceName,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; (Monitor.Win32.EnumDisplaySettings_EnumMode) currMode++,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; display,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 0))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (refreshRate==display.dmDisplayFrequency)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; validModes.Add(display);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; display = new DEVMODE_Display();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //exactMatch?&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (Monitor.Win32.DEVMODE_Display mode in validModes)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (mode.dmPelsWidth == xPrefered &amp;&amp; mode.dmPelsHeight == yPrefered &amp;&amp; mode.dmBitsPerPel == bpp)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ret = mode;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (ret == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int currScore,bestResult = int.MaxValue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (Monitor.Win32.DEVMODE_Display mode in validModes)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; currScore = MatchAlgorithm(mode.dmPelsHeight,mode.dmPelsWidth);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (Math.Abs(MatchAlgorithm(xPrefered,yPrefered) - currScore) &lt; bestResult &amp;&amp; mode.dmBitsPerPel == bpp)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bestResult =&nbsp; (int)Math.Abs(MatchAlgorithm(xPrefered , yPrefered) - currScore);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ret = mode;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return ret;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; public static void CycleRefreshRate(uint monitorIndex, uint refreshRate, uint xPrefered, uint yPrefered)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.DISPLAY_DEVICE displayDevice = new Monitor.Win32.DISPLAY_DEVICE();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int result = Monitor.Win32.EnumDisplayDevices(null, monitorIndex, displayDevice, 0);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (result != 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.DEVMODE_Display devMode = new Monitor.Win32.DEVMODE_Display();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; devMode = GetClosestRefreshRate(displayDevice, xPrefered, yPrefered, refreshRate);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (devMode == null) return; // no valid mode at all.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; devMode.dmDisplayFrequency = refreshRate;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Monitor.Win32.ChangeDisplaySettings_Result r = Monitor.Win32.ChangeDisplaySettingsEx(displayDevice.DeviceName, devMode,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; IntPtr.Zero, Monitor.Win32.ChangeDisplaySettings_Flags.None, IntPtr.Zero);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }Removing &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (ret == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; int currScore,bestResult = int.MaxValue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (Monitor.Win32.DEVMODE_Display mode in validModes)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; currScore = MatchAlgorithm(mode.dmPelsHeight,mode.dmPelsWidth);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (Math.Abs(MatchAlgorithm(xPrefered,yPrefered) - currScore) &lt; bestResult &amp;&amp; mode.dmBitsPerPel == bpp)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bestResult =&nbsp; (int)Math.Abs(MatchAlgorithm(xPrefered , yPrefered) - currScore);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ret = mode;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }[/code]from GetClosestRefreshRateand passing the current resolution to CycleRefreshRate would solve the problem.&nbsp; A bool return would probably be useful too.I haven't include the Desktop Window Manager code as I haven't got around to that yet.</blockquote>

[QUOTE="davidf, post: 571781, member: 19484"] I noticed that there is an open Mantis item opened against picking a rate which is not valid. I had a slight issue where my 1:1 Pixel mapping was only available at 60Hz and as I live in a PAL region I had startred to modify the code to allow the resolution to change to get the desired refresh rate (I think refresh rate is more important than perfect pixel mapping) and the code I have started may solve the issue for Sythe42. This is the code I added to Monitor.cs: [code] //assume total pixels count will be a good match static int MatchAlgorithm(uint Xpels, uint yPels) { return (int)Xpels * (int)yPels; } static DEVMODE_Display GetClosestRefreshRate(Monitor.Win32.DISPLAY_DEVICE displayDevice, uint xPrefered, uint yPrefered, uint refreshRate) { List<Monitor.Win32.DEVMODE_Display> validModes = new List<DEVMODE_Display>(); Monitor.Win32.DEVMODE_Display ret = null; uint bpp=32; Monitor.Win32.DEVMODE_Display display = new DEVMODE_Display(); if (0!=Monitor.Win32.EnumDisplaySettingsEx(displayDevice.DeviceName, Monitor.Win32.EnumDisplaySettings_EnumMode.ENUM_CURRENT_SETTINGS, display, 0)) { bpp = display.dmBitsPerPel; } int currMode = 0; while (0!=Monitor.Win32.EnumDisplaySettingsEx(displayDevice.DeviceName, (Monitor.Win32.EnumDisplaySettings_EnumMode) currMode++, display, 0)) { if (refreshRate==display.dmDisplayFrequency) { validModes.Add(display); display = new DEVMODE_Display(); } } //exactMatch? foreach (Monitor.Win32.DEVMODE_Display mode in validModes) { if (mode.dmPelsWidth == xPrefered && mode.dmPelsHeight == yPrefered && mode.dmBitsPerPel == bpp) { ret = mode; break; } } if (ret == null) { int currScore,bestResult = int.MaxValue; foreach (Monitor.Win32.DEVMODE_Display mode in validModes) { currScore = MatchAlgorithm(mode.dmPelsHeight,mode.dmPelsWidth); if (Math.Abs(MatchAlgorithm(xPrefered,yPrefered) - currScore) < bestResult && mode.dmBitsPerPel == bpp) { bestResult = (int)Math.Abs(MatchAlgorithm(xPrefered , yPrefered) - currScore); ret = mode; } } } return ret; } public static void CycleRefreshRate(uint monitorIndex, uint refreshRate, uint xPrefered, uint yPrefered) { Monitor.Win32.DISPLAY_DEVICE displayDevice = new Monitor.Win32.DISPLAY_DEVICE(); int result = Monitor.Win32.EnumDisplayDevices(null, monitorIndex, displayDevice, 0); if (result != 0) { Monitor.Win32.DEVMODE_Display devMode = new Monitor.Win32.DEVMODE_Display(); devMode = GetClosestRefreshRate(displayDevice, xPrefered, yPrefered, refreshRate); if (devMode == null) return; // no valid mode at all. devMode.dmDisplayFrequency = refreshRate; Monitor.Win32.ChangeDisplaySettings_Result r = Monitor.Win32.ChangeDisplaySettingsEx(displayDevice.DeviceName, devMode, IntPtr.Zero, Monitor.Win32.ChangeDisplaySettings_Flags.None, IntPtr.Zero); } } Removing if (ret == null) { int currScore,bestResult = int.MaxValue; foreach (Monitor.Win32.DEVMODE_Display mode in validModes) { currScore = MatchAlgorithm(mode.dmPelsHeight,mode.dmPelsWidth); if (Math.Abs(MatchAlgorithm(xPrefered,yPrefered) - currScore) < bestResult && mode.dmBitsPerPel == bpp) { bestResult = (int)Math.Abs(MatchAlgorithm(xPrefered , yPrefered) - currScore); ret = mode; } } } [/code] from GetClosestRefreshRate and passing the current resolution to CycleRefreshRate would solve the problem. A bool return would probably be useful too. I haven't include the Desktop Window Manager code as I haven't got around to that yet. [/QUOTE]

Verification