Blue Vision (7 Viewers)

[ge2301]

@morpheus_xx
in current mediastyles.xaml is no style for Seasons existing. Where is the style defined? In \Source\UI\UiComponents\SkinBase\Skin\default I also couldn't see anything.

 

[Lehmden]

Hi.
Got some more crashes lately. Seems to be related to the skin that's why I post it here:

[2015-05-24 21:36:23,105] [15559771] [InputMgr ] [ERROR] - CommandBaseMarkupExtension: Error executing command '{CommandStencil Source=MediaPortal.UiComponents.BlueVision.Models.HomeMenuModel,Path=OnGroupItemSelectionChanged}'
System.Reflection.TargetInvocationException: Ein Aufrufziel hat einen Ausnahmefehler verursacht. ---> MediaPortal.UI.Presentation.Workflow.WorkflowManagerLockException: The workflow manager cannot be locked for read operation 'CurrentNavigationContext' (deadlock?)
bei MediaPortal.UI.Services.Workflow.WorkflowManager.EnterReadLock(String operation)
bei MediaPortal.UI.Services.Workflow.WorkflowManager.get_CurrentNavigationContext()
bei MediaPortal.UiComponents.BlueVision.Models.HomeMenuModel.NavigateToHome()
bei MediaPortal.UiComponents.BlueVision.Models.HomeMenuModel.SetGroup(String groupId)
bei MediaPortal.UiComponents.BlueVision.Models.HomeMenuModel.OnGroupItemSelectionChanged(Object sender, SelectionChangedEventArgs e)
--- Ende der internen Ausnahmestapelüberwachung ---
bei System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
bei System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
bei MediaPortal.UI.SkinEngine.MarkupExtensions.CommandBaseMarkupExtension.Execute(IEnumerable`1 parameters)

Client freezes and I need to kill it by taskmanager.
Full logs attached.

By the way I'm, pretty sure I don't wanted to "GroupItemSelectionChange"

 

[ge2301]

thanks for sharing the logfiles. Seems really a bug in the HomeMenuModel.
I have also 2 minor bugs, with the HomeMenuModel, so I'll list everything tomorrow.
it would be nice if those issues can be resolved before next release by a dev.

 

[morpheus_xx]

in current mediastyles.xaml is no style for Seasons existing. Where is the style defined? In \Source\UI\UiComponents\SkinBase\Skin\default I also couldn't see anything.

Here it is defined: https://github.com/MediaPortal/Medi...s/default/styles/MediaStyles.xaml#L1376-L1386.

 

[ge2301]

Here the summary of points related to HomeMenuModel that need to be changed:

Bugs:

• HomeMenuModel causes freeze of MP2 at GroupItemSelectionChange LINK DONE
  
• When leaving and rentering the GroupMenu, automatically the last selected Item should be reselected --> no switch of screen. In some cases this is not working and the GroupMenu switches to the neighboor item LINK DONE
• The last selected GroupMenuItem should be highlighted "white" until another item is selected. In some cases ( news, Onlinevideos --> going until details) the focus is lost DONE

Optimization:

• Add the possibility to disable autoselect function of GroupMenuItems (click necessary to select the Item) LINK OPEN
• New GroupMenu entry "Currently playing" with play symbol - Entry appears only, if at least one media item is playing OR a info button is selected for MI LINK LINK OPEN

@morpheus_xx @osre I know that both of you are busy. But could you have at least a look on the bugs. Would be really great, if those can be eliminated until the next release
Regarding the optimisation a skin settings screen needs to be implemented at first. At the moment I'm not sure, hat we can do that. I'll prepare a sketch with options for BV

 

[ge2301]

Here a concept for the BV skin settings:

 

[morpheus_xx]

I try to take a look at the known bugs.

For the settings I'd recommend to use themes for the color settings. Then you have a theme with "background.jpg" which is different for all themes and you can also modify some other values.

The other settings are ok to be shared among themes.

 

[ge2301]

I try to take a look at the known bugs.
For the settings I'd recommend to use themes for the color settings. Then you have a theme with "background.jpg" which is different for all themes and you can also modify some other values.
The other settings are ok to be shared among themes.

Ok, with the colors I agree. The settings can conflict with themes, so it's better to leave it open to modders

 

[Lehmden]

Hi.
Another suggestion, not urgency but I did not want it to be forgotten....
When you have a look at this view:

you can not see if an entry is a folder or a media item. Here it's the recordings share (and the first two are folders, the last one is a file) but you will have the same while browse media...
I really would like to have a tiny icon in front (left) of the list entry to see at first glance whether it's a file or a folder...

Edit:
Another option would be to show a folder icon at the place where the "watched eye" is displayed as this never will happen on folder, I think.

 

[morpheus_xx]

@ge2301 I wanted to refactor the shadow definitions and moved out the code into a resource. I checked the different combination, so that I don't accidently remove your values again

One question though: is it intended that there are following combinations of Margin and Row/Column Height/Widths:

• -3 / 18 (1x in MediaStyles.xaml)
  
• -3 / 19 (2x in MediaStyles.xaml)
  
• -3.5 / 22 (1x in MediaStyles.xaml + 1x MediaItemFanart.inc)
  
• -3.5 / 24 (2x in MediaStyles.xaml)
• -4 / 24 (1x in OtherControls.xaml)

The styles looks like:

  <Style x:Key="Shadow_3_18">
    <Setter Property="Template">
      <Setter.Value>
        <ControlTemplate>
          <Grid Margin="-3">
            <Grid.ColumnDefinitions>
              <ColumnDefinition Width="18" />
              <ColumnDefinition Width="*"/>
              <ColumnDefinition Width="18" />
            </Grid.ColumnDefinitions>
            <Grid.RowDefinitions>
              <RowDefinition Height="18" />
              <RowDefinition Height="*"  />
              <RowDefinition Height="18" />
            </Grid.RowDefinitions>
            <Image Grid.Row="0" Grid.Column="0" Stretch="Fill" Margin="0" Opacity="0.9" Source="shadow_00.png" />
            <Image Grid.Row="1" Grid.Column="0" Stretch="Fill" VerticalAlignment="Stretch" HorizontalAlignment="Stretch" Margin="0" Opacity="0.9" Source="shadow_10.png" />
            <Image Grid.Row="2" Grid.Column="0" Stretch="Fill" Margin="0" Opacity="0.9" Source="shadow_20.png" />
            <Image Grid.Row="0" Grid.Column="1" Stretch="Fill" VerticalAlignment="Stretch" HorizontalAlignment="Stretch" Margin="0" Opacity="0.9" Source="shadow_01.png" />
            <Image Grid.Row="1" Grid.Column="1" Stretch="Fill" VerticalAlignment="Stretch" HorizontalAlignment="Stretch" Margin="0" Opacity="0.9" Source="shadow_11.png" />
            <Image Grid.Row="2" Grid.Column="1" Stretch="Fill" VerticalAlignment="Stretch" HorizontalAlignment="Stretch" Margin="0" Opacity="0.9" Source="shadow_21.png" />
            <Image Grid.Row="0" Grid.Column="2" Stretch="Fill" Margin="0" Opacity="0.9" Source="shadow_02.png" />
            <Image Grid.Row="1" Grid.Column="2" Stretch="Fill" VerticalAlignment="Stretch" HorizontalAlignment="Stretch" Margin="0" Opacity="0.9" Source="shadow_12.png" />
            <Image Grid.Row="2" Grid.Column="2" Stretch="Fill" Margin="0" Opacity="0.9" Source="shadow_22.png" />
          </Grid>
        </ControlTemplate>
      </Setter.Value>
    </Setter>
  </Style>

The new styles then can be used this way:

      <!-- SHADOW -->
      <Control Style="{ThemeResource Shadow_35_22}" />
      <!-- SHADOW -->

I tried to remove the redundancies of grid definitions, but unfortunately I could not make it working. The "DynamicResource" is not evaluated to RowDefintion's Height property. So I have a style for each combination now
But at least I could move the duplicated inline styles into a single resource file ("widgets.xaml") now.