Blue Vision (1 Viewer)

[ge2301]

Thats interesting. The RadioButton text color in WPF can be changed by "Foreground" property.
Because this is not possible in MPF, I was looking for the source code of a RadioButton: https://github.com/MediaPortal/Medi...UI/SkinEngine/Controls/Visuals/RadioButton.cs

There is not even something about "content" property. I set the content to "test" and a white text "test" appears in the button.
How does MP2 know it needs to be white? I can't believe, that this is a standard setting ...

 

[osre]

Thats interesting. The RadioButton text color in WPF can be changed by "Foreground" property.
Because this is not possible in MPF, I was looking for the source code of a RadioButton: https://github.com/MediaPortal/Medi...UI/SkinEngine/Controls/Visuals/RadioButton.cs

There is not even something about "content" property. I set the content to "test" and a white text "test" appears in the button.
How does MP2 know it needs to be white? I can't believe, that this is a standard setting ...

RadioButton is a subtype of Button->ContentControl->Control. ContentControl has the content property.
In WPF, Foreground is a property from Control I think, and as long as this property is not explicitly set, the value from the parent(s) is used.
I would welcome if we could extend MPF by the Foreground property as well, since it's quite usefull.
How MPF decides what text color it should use for string content I don't know.

 

[morpheus_xx]

I'd like to have only one CP screen, that defines the Content according to AspectWrapper. Than means get rid of "CurrenlyPlayingAudio" etc. But not sure how I can make MP2 make ignore those, since they are in Default skin implemented.

As explained somewhere earlier before: each player can define it's own CP and FS (Fullscreen) screens. That's because each can provide different data to the screens.

You could already use a common include file for all CP screens: i.e. you create a "CurrentlyPlayingMedia.inc" which decides which detail to be shown.

The you can include this one inside "CurrentlyPlayingAudio". But the problem with this approach is, that you first put everything together into one file and then need to conditionally hide/show items. Using each file already provides you separation of valid information. So generally spoken this is not the best way to provide screens for audio/image/video(+movie/+series)

 

[morpheus_xx]

• A first chance exception of type 'System.NullReferenceException' occurred in SkinEngine.dll

• [19:21:55,833] [AMQ 'ScreenManager'] [ERROR] - Unhandled exception in message handler of async message queue 'ScreenManager' when handling a message of type 'ShowScreen'

• System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt.

bei MediaPortal.UI.SkinEngine.Rendering.TextBuffer.TextHeight(Int32 lineCount)

Oh, this is a new issue The method only contains one call: https://github.com/MediaPortal/Medi...ce/UI/SkinEngine/Rendering/TextBuffer.cs#L249

So it must be _font that is null, which would mean that there is something wrong with allocation (or a race condition).

I hope I have fixed this by adding sanity checks.

 

[ge2301]

I'm back home finally. With current temperatures I should acually swim, but I did a few things on BV

• I pushed a bugfix for the focus frame / background opacities. Everything looks well now
• Currently Playing screen
  • The focus indicator is currently done by a small growing in y-direction. I really don't like it, but could not implement a Label into the button changing the text color. So it must be like this for the moment
  • Status in MediaInfo screen
    • I added in images subfolders with MediaInfo images, which are already loaded for Video- and AudioEncoding. Same is planned for most of other infos. For audio languages I'll add country flags.
      
    • The width property gives incorrect outputs: NaN instead of 1280. Any idea why?
    • Subtitle infos are missing (Question: If and when those will be added?)
    • How about audio infos for the second audio track? (e.g. Bitrate, ...) Seems not possible at the moment.

How can I use a image source binding with rounded values? Problem is, that the AspectRatio values are too long and differ from those shown in MediaInfo.dll
Below code does not work, but shows what I try to do

            <Image Grid.Row="3" Grid.Column="0" HorizontalAlignment="Stretch" VerticalAlignment="Stretch" Stretch="Uniform" Width="300" >
              <Image.Source>
                <Binding Path="AspectRatio" ContentStringFormat="{}{0:#}" Converter="{StaticResource StringFormatConverter}" ConverterParameter="{}Medialogos\aspectratio\{0}.png"/>
              </Image.Source>
            </Image>

If there are 2 audio languages (English, German) I receive a string "en de".
How can I split the string and accordingly load 2 images? I couldn't find a feasible converter for that in MPF

Ok, enough questions

 

[morpheus_xx]

If there are 2 audio languages (English, German) I receive a string "en de".

Audio languages are list of strings:

public IEnumerable<string> AudioLanguages

, so you should be able to use a ListView on that Property and define ContentTemplates for your needs (I've not tested it yet).

The width property gives incorrect outputs: NaN instead of 1280. Any idea why?

No idea, need to check this in a test case. The property is a nullable int (int?).

How about audio infos for the second audio track? (e.g. Bitrate, ...) Seems not possible at the moment.

Unfortunately this is a bit inconsistant:

• audio bitrate is the one of first audio track.
• audio codecs are concatenated by ", ": MediaItemAspect.SetAttribute(extractedAspectData, VideoAspect.ATTR_AUDIOENCODING, StringUtils.Join(", ", _audCodecs)); So here you might indeed do some splitting. Don't have a solution for this in short time.

Subtitle infos are missing (Question: If and when those will be added?)

Subtitles are not yet considered, as different players can support different sources: even if the importer doesn't know external subtitles, the player might load them from file or even an online source. So for now this information is not available.

 

[morpheus_xx]

Now I've got my BlueVision Menu completely overworked as I like it. While doing this I've made a new button for "Latest media" I've attached this button and my config- file here too

@Lehmden would you like to include your complete grey theme into the SummerRelease? If so, please attach a full version of the theme here so I can commit it.

 

[Lehmden]

Hi.

complete grey theme into the SummerRelease?

Yes, that would be nice. One question is about the two different tiles for "latest media". The original one is square (as it is shown in "others" menu) and the new one is landscape oriented as I use it on "regular" menu positions. Which one (or both) should I include? The square one is not as good looking as the second one, but I never tested the new one on square tile positions...
The config file is no part of the theme, I think as it can not be used from inside the theme folder. Am I right? I've modified the config file to my personal needs so other people may want other menu structure. Should this be included if it's possible at all?

 

[morpheus_xx]

The config file is no part of the theme, I think as it can not be used from inside the theme folder. Am I right? I've modified the config file to my personal needs so other people may want other menu structure. Should this be included if it's possible at all?

Right, settings are defined per skin, not theme. I've also re-checked your screenshots above, probably the "Images" tile is showing a bit too much skin, if you understand what I mean Not that I personally would have a problem with this, but it's probably not the best to include into a public release.

So maybe it's better to keep it as additional download, you than can offer it without changes and also include your customized tile arrangement.

For a future release we can think about theme specific settings...

 

[Lehmden]

Hi.
The "Images" tile I would not include at all, this is for me only. I don't have self made music, movies or series, but I have self made images. That's why I use the images in "my" MP2.
The "rest" of the skin is usable and nice looking without the modified config file. I've attached the complete theme here (w/o the images tile and the config file). Later today I can provide some screenshots without modified settings and in English language. ATM I'm working on my Raspberry Pi via RDP. And during a RDP session MP2 client did not start at all...

Edit: The 7z contains both "Latest Media" buttons, so the user can choose which one to use.