Hi,
I'm not sure, whether this is a bug, just wanted to mention it somewhere and ask some silly questions
I tried to play a bluray iso with MP2-client and it tells me that there is no player registered for it. When stepping through the code I realized that it's not the player that's missing. It seems to be the fact that I don't have the Gabest sourcefilter installed (only LAV) and Gabest is hardcoded as sourcefilter in the BDHandler plugin for MP2.
Over my holidays, I tried to understand some more of MP2's code and tried to add support for LAV (i.e. replace Gabest with LAV in the code). And guess what: it worked. As I was starting to code, I wanted to dig deeper and decided to make the sourcefilter for MP2-Client a configurable setting. It worked as well (and I was really proud of myself) but I came across the following question / problem:
I somehow had to include some sort of default-setting for this sourcefilter, because if I didn't, bluray playback didn't work, when I started up MP2-Client for the first time. I first had to go into settings and chose a sourcefilter. After that it worked. The question is: How to do that. I know I can set a default setting in the attribute of the settings class. The problem with this solution is that there is no hardcoded default for this setting. What I wanted to achieve is that I check whether LAV is installed, if so use LAV as default, if LAV is not installed, check whether Gabest is installed, if so use this one as default. But obviously, I can't set the default attribute to some kind of method to be called. What I tried next is to use the constructor of the respective configuration class. But this class doesn't seem to be instatiated unless you enter the settings.
Where is the right place to do this? Is it the constructor of the settings class?
As mentioned, all this happened during my holidays and I wanted to post this question and/or a patch earlier, but then I found the thread in the MP1-forum about native bluray support. I was absolutely sure that it wouldn't take too long until someone ports this to MP2 and I should be right (Thanks Morpheus, much appreciated, didn't test, yet, but I will). Anyway, I tried to read some of the code in the new bluray branch and my understanding is that there is a separate sourcefilter for blurays now.
That means for me that there is no need for Gabest or LAV as sourcefilter for blurays anymore. Am I correct? What are the plans in this direction? Does it still make sense that I finish my patch above?
ok, that's a lot of text and many questions. Any answer is welcome...
Michael
I'm not sure, whether this is a bug, just wanted to mention it somewhere and ask some silly questions
I tried to play a bluray iso with MP2-client and it tells me that there is no player registered for it. When stepping through the code I realized that it's not the player that's missing. It seems to be the fact that I don't have the Gabest sourcefilter installed (only LAV) and Gabest is hardcoded as sourcefilter in the BDHandler plugin for MP2.
Over my holidays, I tried to understand some more of MP2's code and tried to add support for LAV (i.e. replace Gabest with LAV in the code). And guess what: it worked. As I was starting to code, I wanted to dig deeper and decided to make the sourcefilter for MP2-Client a configurable setting. It worked as well (and I was really proud of myself) but I came across the following question / problem:
I somehow had to include some sort of default-setting for this sourcefilter, because if I didn't, bluray playback didn't work, when I started up MP2-Client for the first time. I first had to go into settings and chose a sourcefilter. After that it worked. The question is: How to do that. I know I can set a default setting in the attribute of the settings class. The problem with this solution is that there is no hardcoded default for this setting. What I wanted to achieve is that I check whether LAV is installed, if so use LAV as default, if LAV is not installed, check whether Gabest is installed, if so use this one as default. But obviously, I can't set the default attribute to some kind of method to be called. What I tried next is to use the constructor of the respective configuration class. But this class doesn't seem to be instatiated unless you enter the settings.
Where is the right place to do this? Is it the constructor of the settings class?
As mentioned, all this happened during my holidays and I wanted to post this question and/or a patch earlier, but then I found the thread in the MP1-forum about native bluray support. I was absolutely sure that it wouldn't take too long until someone ports this to MP2 and I should be right
(Thanks Morpheus, much appreciated, didn't test, yet, but I will). Anyway, I tried to read some of the code in the new bluray branch and my understanding is that there is a separate sourcefilter for blurays now.That means for me that there is no need for Gabest or LAV as sourcefilter for blurays anymore. Am I correct? What are the plans in this direction? Does it still make sense that I finish my patch above?
ok, that's a lot of text and many questions. Any answer is welcome...
Michael
Germany