Change to MyRSS (1 Viewer)

AndyQ

Portal Member
May 27, 2005
25
0
I'm made the following changes to MyRSS to allow the display of the full story of an RSS article:

When an RSS article is clicked, the full article is retrieved, converted to text and displayed in a Dialog.

To do this I've added a new dialog - DialogText which is based on the DialogMenu but has a textarea instead of a list box. I've also added the skin xml files, a HtmlToText Util class (I put it in Core/Util), a new Window ID (7900) for the DialogText and a couple of changes to the Window PLugin GUIRSSFeed.

I've submitted a patch to sourceforge (I eventually noticed the sticky in this forum) - is this still the correct way of submitting changes?

Cheers
Andy
 

critifer

Portal Pro
February 9, 2005
53
0
Andy - First THANKS!!! The RSS plugin is very nice and would love to see anything else u may be able to add to it - interactive stock ticker....

There are also some var's I'd like to have from the RSS reader than could be global passed from skin page to skin page to have headline news on certain pages. Frodo and I have discussed this with this module as well as a few others, i.e. weather.

I will make Frodo aware of this change tomorrow - but could u please PM him and make note of the source changes.

Again - THANKS!!! please feel free to add the creativity where u can ...

Regards - Crit

AndyQ said:
I'm made the following changes to MyRSS to allow the display of the full story of an RSS article:

When an RSS article is clicked, the full article is retrieved, converted to text and displayed in a Dialog.

To do this I've added a new dialog - DialogText which is based on the DialogMenu but has a textarea instead of a list box. I've also added the skin xml files, a HtmlToText Util class (I put it in Core/Util), a new Window ID (7900) for the DialogText and a couple of changes to the Window PLugin GUIRSSFeed.

I've submitted a patch to sourceforge (I eventually noticed the sticky in this forum) - is this still the correct way of submitting changes?

Cheers
Andy
 

Boilermaker

Retired Team Member
  • Premium Supporter
  • May 21, 2004
    519
    3
    Thanks for adding a feature the RSS feeds sorely lacked...I figured the ability to read the entire story wouldn't be implemented until somebody integrated a web browser into mp, but thankfully i was wrong. Will be keeping an eye on the cvs versions for the additions.
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    OOps - thought I'd attached them - possibly can only attach files if you have a SF id.

    Files have been submitted - (I had to create a new patch 1248411).

    Oh yeah, one thing, the HtmlToText convertor is pretty much an initial straight port across of the Vilistextum C program - I do plan on cleaning this up a little as it isn't remotely OO and there is no way really yet to change behaviour (like turning on/off various properties). The functionality to do this is all there but just no way of doing it yet :)
     

    mPod

    Portal Pro
    January 26, 2005
    2,084
    3
    Berlin
    Home Country
    Germany Germany
    There are some issues in your patch that I like to see busted before I can put it into CVS.

    Among them:

    - Sometimes special characters (e.g. German Umlauts) are not displayed at all.
    - It looks like not only the article shows up in the window, but everything else that is on the details page, including links, ads and so on.
    - For some articles the text is truncated at the beginning, which renders your modifications a bit useless, because you only see some bits of the article.
    - Sometimes calling the details only works for the first time. Subsequent calls bring up the error message, that the rss feed cannot be received.

    But I must say, it's a very good start. I really like your modifications. :wink:

    Streams I tested (for your reference to debug):

    http://www.tagesschau.de/newsticker.rdf
    http://www.spiegel.de/schlagzeilen/rss/0,5291,,00.xml
    http://www.spiegel.de/schlagzeilen/rss/0,5291,23,00.xml
    http://www.spiegel.de/schlagzeilen/rss/0,5291,24,00.xml
    http://www.heise.de/newsticker/heise.rdf
    http://www.heise.de/tp/news-xl.rdf
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    Yeah, I haven't translated all special character tags yet (these I gues scome across as &xxxx; Currently only translations fo rthe most common elements are included (& < >) however I'll add the rest in.

    Regarding the whole page - Its not obvious what not to include from the entire article as the article link points to the complete page for the story. I can add some options to strip out links but picking out the article text from other text is going to be very tricky (I thiink)
     

    AndyQ

    Portal Member
    May 27, 2005
    25
    0
    OK, I've fixed most of the issues.

    The Links one is bit tricky because some articles have links as part of their text so if you remove all links then some of the text will be missing, however I've removed all img links which cleans it up a bit.

    Any ideas/suggestions to improve the display or identify headers and other junk on the article page gratefully recieved.

    I've fixed a number of issues that caused the error message to display (mainly caused by differences between the way C looks and parses strings and the way C# does - features not bugs :)).

    The missing characters was a bugger to fix but I think I've done it. I use the Encoding specified by the Response stream defaulting to CodePage 1252 if not specified.

    Couldn't replicate the text trucated issue but that may have been due to one of the bugs I've fixed - would be grateful if you replicate it to let me know which article caused it.
     

    Users who are viewing this thread

    Top Bottom