home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Area 51 - Testing Area
Changing channel using numbers does not work across group
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="mm1352000" data-source="post: 1198206" data-attributes="member: 82144"><p>Just reviewing the current change...</p><p></p><p></p><p>I agree, this is very important. In my opinion people will expect to stay within the current group unless they explicitly select a channel that is not in the current group.</p><p></p><p>Having looked at the code more thoroughly now...</p><p>What you've got generally looks good. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite24" alt="(y)" title="Thumbs Up (y)" loading="lazy" data-shortname="(y)" /></p><p>Only two additional comments (opinions! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" /> ):</p><ol> <li data-xf-list-type="ol">I think it would be more consistent <em>not</em> to try to avoid going to the all channels group. If people want to avoid the all channels group, they can use the "hide all channels group" setting... or simply configure it to be the last group. (As you know, groups have a defined sort order. m_groups is already sorted according to that ordering and excludes the all channels group according to the setting value. After checking the current group, you could simply iterate over m_groups until you find the channel.)</li> <li data-xf-list-type="ol">If possible, I would only <a href="https://github.com/MediaPortal/MediaPortal-1/blob/d8019abdb63e1e8d3c63ed95cb0c2504b737bef4/TvEngine3/TVLibrary/TvPlugin/TvPlugin/TVHomeNavigator.cs#L662" target="_blank">set the current group</a> after <em>trying </em>to select the target channel, and <em>only</em> if zapping is successful.</li> </ol><p>I was also going to add that the all channels group could be completely skipped if the user has ticked the "hide all channels group" option, but the current code already does that (m_groups is filtered on initial load). <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite24" alt="(y)" title="Thumbs Up (y)" loading="lazy" data-shortname="(y)" /></p><p></p><p>Thanks! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" /></p></blockquote><p></p>
[QUOTE="mm1352000, post: 1198206, member: 82144"] Just reviewing the current change... I agree, this is very important. In my opinion people will expect to stay within the current group unless they explicitly select a channel that is not in the current group. Having looked at the code more thoroughly now... What you've got generally looks good. (y) Only two additional comments (opinions! :) ): [LIST=1] [*]I think it would be more consistent [I]not[/I] to try to avoid going to the all channels group. If people want to avoid the all channels group, they can use the "hide all channels group" setting... or simply configure it to be the last group. (As you know, groups have a defined sort order. m_groups is already sorted according to that ordering and excludes the all channels group according to the setting value. After checking the current group, you could simply iterate over m_groups until you find the channel.) [*]If possible, I would only [URL='https://github.com/MediaPortal/MediaPortal-1/blob/d8019abdb63e1e8d3c63ed95cb0c2504b737bef4/TvEngine3/TVLibrary/TvPlugin/TvPlugin/TVHomeNavigator.cs#L662']set the current group[/URL] after [I]trying [/I]to select the target channel, and [I]only[/I] if zapping is successful. [/LIST] I was also going to add that the all channels group could be completely skipped if the user has ticked the "hide all channels group" option, but the current code already does that (m_groups is filtered on initial load). (y) Thanks! :) [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Area 51 - Testing Area
Changing channel using numbers does not work across group
Contact us
RSS
Top
Bottom
