home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Area 51 - Testing Area
Changing channel using numbers does not work across group
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="mm1352000" data-source="post: 1198402" data-attributes="member: 82144"><p>I don't think this is something you should have to care about. If people are bothered by performance issues related to the all channels group, they can use the "hide all channels group" setting or configure the all channels group to be the last group.</p><p></p><p></p><p>If the current group is the all channels group, the channel is guaranteed to be found. Therefore you don't need any special stop handling for the all channels group.</p><p></p><p></p><p>As explained in my previous reply, I don't think that the all channels group should be given special treatment with regard to ordering either. Surely it's far better to be consistent with the [configurable] channel group ordering. That way people can configure their ordering to get the behaviour <em>they</em> want.</p><p></p><p></p><p>As above: I don't think you should be concerned about this.</p><p>Another way to look at this would be to consider that forcing the all channels group to be checked last actually adds overhead if the target channel is only present in the all channels group.</p><p></p><p></p><p>Note that channel numbers are not guaranteed to be unique.</p><p></p><p></p><p>I'm not sure why you think that. Implementing zapping using a dictionary wouldn't take much more code. Less than 10 extra lines? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink ;)" loading="lazy" data-shortname=";)" /></p><p></p><p></p><p>I had a look myself, and in doing so I discovered code in both the TV guide and radio guide:</p><p><a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/TvGuideBase.cs#L4110" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/TvGuideBase.cs#L4110</a></p><p><a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/RadioGuideBase.cs#L3800" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/RadioGuideBase.cs#L3800</a></p><p></p><p>It looks like the purpose is to find a channel in the guide by its channel number.</p><p>Here the TV and radio code seems to be very similar.</p><p>Both of them will need to be extended in the same way as the navigator code.</p></blockquote><p></p>
[QUOTE="mm1352000, post: 1198402, member: 82144"] I don't think this is something you should have to care about. If people are bothered by performance issues related to the all channels group, they can use the "hide all channels group" setting or configure the all channels group to be the last group. If the current group is the all channels group, the channel is guaranteed to be found. Therefore you don't need any special stop handling for the all channels group. As explained in my previous reply, I don't think that the all channels group should be given special treatment with regard to ordering either. Surely it's far better to be consistent with the [configurable] channel group ordering. That way people can configure their ordering to get the behaviour [I]they[/I] want. As above: I don't think you should be concerned about this. Another way to look at this would be to consider that forcing the all channels group to be checked last actually adds overhead if the target channel is only present in the all channels group. Note that channel numbers are not guaranteed to be unique. I'm not sure why you think that. Implementing zapping using a dictionary wouldn't take much more code. Less than 10 extra lines? ;) I had a look myself, and in doing so I discovered code in both the TV guide and radio guide: [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/TvGuideBase.cs#L4110[/URL] [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/TvEngine3/TVLibrary/TvPlugin/TvPlugin/RadioGuideBase.cs#L3800[/URL] It looks like the purpose is to find a channel in the guide by its channel number. Here the TV and radio code seems to be very similar. Both of them will need to be extended in the same way as the navigator code. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Area 51 - Testing Area
Changing channel using numbers does not work across group
Contact us
RSS
Top
Bottom