Clean and modernize the repo (1 Viewer)

[CSMR]

I'm very glad to see that mediaportal 1 is on github, where ordinary devs with github accounts can make contributions.

Please can you click the checkbox to add Issues to the github repo? This will allow the same devs to discuss issues there. It also enables AI functions e.g. assigning copilot to an issue.

Since issues aren't allowed there I will post here.

There is a lot of modernization work needed on the repo.

There are dll files and exe files in source control! Largely things that are in nuget. The most urgent problem that I see. This is causing build problems, e.g. on building the tests projects:

NuGet Package restore failed for project Plugins\WindowPlugins\GUIMusic: Unable to find version '10.6.0' of package 'DirectX_9_SDK'.
  https://api.nuget.org/v3/index.json: Package 'DirectX_9_SDK.10.6.0' is not found on source 'https://api.nuget.org/v3/index.json'.
. Please see Error List window for detailed warnings and errors.
NuGet Package restore failed for project Core: Unable to find version '3.50.2' of package 'Sqlite'.
  https://api.nuget.org/v3/index.json: Package 'Sqlite.3.50.2' is not found on source 'https://api.nuget.org/v3/index.json'.
. Please see Error List window for detailed warnings and errors.
NuGet Package restore failed for project Core: Unable to find version '2.4.14.1' of package 'BassRegistration'.
  https://api.nuget.org/v3/index.json: Package 'BassRegistration.2.4.14.1' is not found on source 'https://api.nuget.org/v3/index.json'.
. Please see Error List window for detailed warnings and errors.

Presumably there is a some workaround out there, but a better fix is to clean all this up, delete these files, and just add nuget package references.

Will a PR to clean all this up be accepted?
I started work on adding tests for IIMDBScriptGrabber scripts but I'd prefer to fix the above issue first before

Other issues found (to be moved to github issues when enabled)
netframework -> dotnet10
sln files -> slnx
Some slns likely not necessary (e.g. multiple freetype slns, when dotnet has good font rendering libraries), Win7RefreshRateHelper has "Win7" in the name which is obsolete.
Csscript files: These are hard to edit and can be converted to .cs files, removing the need for interpretation, and the availability of the github repo means these can be changed via PRs instead of submission of csscript files.
The mediaportal install requires microsoft visual C++ which suggests that things are being compiled on user systems

 

[el Filou]

The mediaportal install requires microsoft visual C++ which suggests that things are being compiled on user systems

No, it requires Microsoft Visual C++ Runtimes.
Has this 'analysis' been performed by AI ?

 

[doskabouter]

On my end building works more or less ok, and PR's will be accepted if deemed ok.
Not sure if we want to open the issues... seeing that the number of active developers is quite low and we probably can't handle the surge of ai-related issues that are going to be created

 

[doskabouter]

btw a number of your issues are not going to be done (f.e. netframework -> dotnet)
It's just too much work (its far from a straightforward conversion) or too much risk of breaking something

 

[doskabouter]

I see what is happening with your nuget. The files you're missing are on mediaportal's myget (https://www.myget.org/feed/mediaportal)
Somehow your system isn't picking up on that

 

[doskabouter]

btw, completely forgot that we already have an issue-tracker: Jira

 

[ajs]

is not found on source 'https://api.nuget.org/v3/index.json'.

You are unable to connect to myget (https://www.myget.org/feed/mediaportal). Please check your settings.

  Feeds used:
    https://www.myget.org/F/mediaportal/
 
  Restoring NuGet package DirectX_9_SDK.10.6.0.
  Restoring NuGet package MediaPortal.libbluray.1.1.2.
    GET https://www.myget.org/F/mediaportal/Packages(Id='DirectX_9_SDK',Version='10.6.0')
    GET https://www.myget.org/F/mediaportal/Packages(Id='MediaPortal.libbluray',Version='1.1.2')
    OK https://www.myget.org/F/mediaportal/Packages(Id='DirectX_9_SDK',Version='10.6.0') 262ms
    GET https://www.myget.org/F/mediaportal/api/v2/package/DirectX_9_SDK/10.6.0
    OK https://www.myget.org/F/mediaportal/Packages(Id='MediaPortal.libbluray',Version='1.1.2') 541ms
    GET https://www.myget.org/F/mediaportal/api/v2/package/MediaPortal.libbluray/1.1.2
    OK https://www.myget.org/F/mediaportal/api/v2/package/DirectX_9_SDK/10.6.0 1264ms
    OK https://www.myget.org/F/mediaportal/api/v2/package/MediaPortal.libbluray/1.1.2 1072ms

Will a PR to clean all this up be accepted?

It all depends on the contents of the pull request, but there's a chance

I started work on adding tests for IIMDBScriptGrabber scripts but I'd prefer to fix the above issue first before

Look: GitHub - andrewjswan/mediaportal-grabber-test

Csscript files: These are hard to edit and can be converted to .cs files, removing the need for interpretation, and the availability of the github repo means these can be changed via PRs instead of submission of csscript files.

Csscript files: The advantage is that they can be updated directly from MediaPortal itself without having to rebuild the MediaPortal version; during the current version’s lifecycle, the grabbers (Csscript) have been updated two or three times. If the grabbers were moved to the core, a new version would have to be released, and users would have to download a 200 MB installation package instead of simply clicking a button to update small Csscript files.

add Issues to the github repo

Historically, we’ve always discussed all issues here on the forum. If an issue is confirmed, we create a Jira ticket and then open a pull request on GitHub. If we decide to stop using Jira, we’ll try switching to GitHub.

 

[ajs]

If you’re planning to submit a pull request, let’s go through the list of issues and their solutions.

I or someone from the team will create a Jira ticket, and for each ticket, you’ll make the changes and submit a pull request.

This will be transparent and straightforward.