[Approved] - Clean up some SetupTV UI elements

Discussion in 'Archive' started by mcraenz, July 16, 2011.

  1. mcraenz
    • Premium Supporter

    mcraenz MP Donator

    Joined:
    July 28, 2007
    Messages:
    647
    Likes Received:
    44
    Location:
    Auckland
    Ratings:
    +47 / 0
    Home Country:
    New Zealand New Zealand
    Show System Specs
    This is just a UI tidy up in SetupTV.

    Re-arrange controls on Manual control page

    • TS Packet stats - label is overlapping text box. - Moved controls to the right to prevent over lapping
    • TS Filename label has been completely obscured by packet stats label. - Moved below TS packet stats controls
    • TS Filename label has no place holder text so was invisible to developers. - Added placeholder text
    • Channel info multiline label has no place holder test so was invisible to developers. -Added placeholder text
    • Timeshift info GroupBox is anchored to bottom, it shouldn't be because vertically it's size should be static. Only the top,left and right should stretch when the SetupTv form is re-sized. -Removed anchor to bottom.
    • "Tuner locked". the "yes" and "no" words are all lowercase changed to "Yes" and "No"

    SetupTV Main Form
    • SetupTV main form has no minimum size so can be re-sized so small that the controls get all messed up and overlap each other. Doesn't look professional. -Set minimum size to current default size of : 724, 571. This is done in the InitializeComponent() method. Now calling it in the constructor since it hasn't been called since rev 18493

    TV Cards Page
    • Changed wording for number of IPTV Cards enabled

    Please see attached before and after screen shots
    ManualControlAfter.png

    ManualControlBefore.png



    TVCardsAfter.png

    TVCardsBefore.png
     

    Attached Files:

    • Like Like x 4
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Hi,

    I can't comment on the code quality, but this looks good and I would say should be included.

    Best wishes,

    Mark
     
  4. miroslav22
    • Premium Supporter

    miroslav22 Development Group Member

    Joined:
    September 4, 2009
    Messages:
    703
    Likes Received:
    459
    Gender:
    Male
    Location:
    Warwick
    Ratings:
    +459 / 0
    Home Country:
    United Kingdom United Kingdom
    :D

    I've not looked at the code, but as long as there are no functionality changes then there's no reason it can't be committed.

    Edit:

    If the minimum window size has been changed then we might need to be careful actually as it could have a negative affect on other windows.
     
  5. mcraenz
    • Premium Supporter

    mcraenz MP Donator

    Joined:
    July 28, 2007
    Messages:
    647
    Likes Received:
    44
    Location:
    Auckland
    Ratings:
    +47 / 0
    Home Country:
    New Zealand New Zealand
    Show System Specs
    Currently there is no minimum. I have set the minimum to what window opens as. Shouldn't cause an issue any more than if the user opened the app and used it without resizing at all.
     
    • Like Like x 1
  6. mcraenz
    • Premium Supporter

    mcraenz MP Donator

    Joined:
    July 28, 2007
    Messages:
    647
    Likes Received:
    44
    Location:
    Auckland
    Ratings:
    +47 / 0
    Home Country:
    New Zealand New Zealand
    Show System Specs
    I can post a complied SetupTv.exe for testing if it would help?
     
  7. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Hi,

    It can't hurt.

    Mark
     
  8. mcraenz
    • Premium Supporter

    mcraenz MP Donator

    Joined:
    July 28, 2007
    Messages:
    647
    Likes Received:
    44
    Location:
    Auckland
    Ratings:
    +47 / 0
    Home Country:
    New Zealand New Zealand
    Show System Specs
    Here we go.
     

    Attached Files:

    • SetupTv.zip
      File size:
      533.1 KB
      Uploaded:
      July 20, 2011
      Views:
      85
  9. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    Hi folks

    I've tested the patch and it looks perfect to me. I'd be happy to commit at any time.

    mcraenz: a small tip for you (*please*, don't take this the wrong way because I *definitely* appreciate the patch - just a suggestion to help future patches get committed faster). A large amount of the code in the patch file was created because you had used a four space tab size instead of the two space tab size that MediaPortal coding standards asks us to use. When I changed the spacing to two spaces, the size of the patch dropped from 100 kB to 9 kB. Smaller patches are easier to check and may get committed faster. ;)

    Thank you for the patch! :D

    mm

    PS: updated patch attached
     

    Attached Files:

  10. SilentException
    • Premium Supporter

    SilentException Retired Team Member

    Joined:
    October 27, 2008
    Messages:
    2,617
    Likes Received:
    1,125
    Gender:
    Male
    Location:
    Rijeka, Croatia
    Ratings:
    +1,129 / 0
    Home Country:
    Croatia Croatia
    No need to apologize mm. All patches are to follow the guidelines :)
     
  11. mm1352000
    • Team MediaPortal

    mm1352000 Development Group

    Joined:
    September 1, 2008
    Messages:
    21,527
    Likes Received:
    4,738
    Ratings:
    +8,205 / 17
    Home Country:
    New Zealand New Zealand
    Hi again everyone

    The patch is committed in SVN 28077. Cheers mcraenz. :)

    mm
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!