home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Submit: Bug Reports
Design issue? Assumption in code doesn't seem to be true...
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="MrINTJ" data-source="post: 1284749" data-attributes="member: 167880"><p>Before you create this bug report:</p><ol> <li data-xf-list-type="ol">Make sure that your system <em>(Windows, codecs and drivers)</em> is up to date, matching the <a href="https://www.team-mediaportal.com/wiki/display/MediaPortal2/Installing+MediaPortal+2" target="_blank"><strong>Requirements</strong></a> and you've filled in your <a href="http://forum.team-mediaportal.com/account/systemspecs" target="_blank"><strong>System Specs.</strong></a></li> <li data-xf-list-type="ol">Have a look at our <a href="https://www.team-mediaportal.com/wiki/display/MediaPortal2" target="_blank"><strong>MediaPortal Wiki!</strong></a> Maybe the solution is already there.</li> <li data-xf-list-type="ol">Have a look at our <strong><a href="https://issues.team-mediaportal.com/issues/?jql=project%20%3D%20MP2%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC" target="_blank">Jira (Bug and Issue Tracker)</a></strong>and the threads in this section, maybe your problem is already known.</li> <li data-xf-list-type="ol">Search the forums for your problem, it's very likely that someone else already encountered the same problem.</li> </ol><p></p><p><strong><em><span style="color: rgb(243, 121, 52)">Please always include log files with your Bug Report!</span></em></strong></p><p>Check out our Wiki: <a href="https://www.team-mediaportal.com/wiki/display/MediaPortal2/Bug+Reports+and+Log+Files" target="_blank"><strong>Bug Reports and Log Files</strong></a></p><p></p><p>==================================================================</p><p></p><p><span style="font-size: 12px"><em>Describe the Problem you encounter as detailed as possible! "It does not work" won't help the team to understand the problem. </em></span></p><p><strong> Description: </strong></p><p></p><p>I noticed on github.com that in <strong>MediaPortal-2/MediaPortal/Source/UI/Players/RefreshRateChanger/RefreshRateChanger.cs</strong>, there seems to be an assumption that the source and target of each path will appear at adjacent indices in _modeInfoArray, e.g. around <strong>line 402</strong>:</p><p></p><p>[CODE]402: var modeIndex = _displayIndex * 2; // Array always contains "Source" and "Target" per display[/CODE]</p><p></p><p>This is generally true, but <em>not always</em>. Specifically, when a display is configured to duplicate another display (rather than extend the desktop).</p><p></p><p>For example, with three GDI displays mapped to three different monitors, you'll get this from [ICODE]QueryDisplayConfig()[/ICODE]:</p><p></p><p><span style="font-family: 'courier new'"> PathIdx | SrcModeIdx | TgtModeIdx</span></p><p><span style="font-family: 'courier new'">---------+------------+------------</span></p><p><span style="font-family: 'courier new'"> 0 | 1 | 0</span></p><p><span style="font-family: 'courier new'"> 1 | 3 | 2</span></p><p><span style="font-family: 'courier new'"> 2 | 5 | 4</span></p><p></p><p>...but if you set the second monitor to duplicate the first (primary) display, you get this:</p><p></p><p><span style="font-family: 'courier new'"> PathIdx | SrcModeIdx | TgtModeIdx</span></p><p><span style="font-family: 'courier new'">---------+------------+------------</span></p><p><span style="font-family: 'courier new'"> 0 | 1 | 0</span></p><p><span style="font-family: 'courier new'"> 1 | <strong>1</strong> | 2</span></p><p><span style="font-family: 'courier new'"> 2 | <strong>4</strong> | <strong>3</strong></span></p><p></p><p>Note that the duplicating display also messes up the [target, source] ordering assumed by the current code.</p><p></p><p>You should be able to confirm this by testing on a system with multiple monitors (two or more), and using <strong>Display settings</strong> to configure the second display to Duplicate the first (primary) display. If you then run the RefreshRateChanger code, you should see an issue.</p><p></p><p>Sorry I don't just submit an MR myself, but I'm not a regular contributor; just happened to spot this while browsing and thought you'd want to know.</p><p></p><p>-MrINTJ</p><p></p><p><em><span style="font-size: 12px">Describe as detailed as possible the steps that are required to encounter the issue. This info is critical for the team to understand the problem. </span></em></p><p><strong> Steps to Reproduce: </strong></p><p></p><p></p><p></p><p></p><p></p><p></p><p></p><p>.</p></blockquote><p></p>
[QUOTE="MrINTJ, post: 1284749, member: 167880"] Before you create this bug report: [LIST=1] [*]Make sure that your system [I](Windows, codecs and drivers)[/I] is up to date, matching the [URL='https://www.team-mediaportal.com/wiki/display/MediaPortal2/Installing+MediaPortal+2'][B]Requirements[/B][/URL] and you've filled in your [URL='http://forum.team-mediaportal.com/account/systemspecs'][B]System Specs.[/B][/URL] [*]Have a look at our [URL='https://www.team-mediaportal.com/wiki/display/MediaPortal2'][B]MediaPortal Wiki![/B][/URL] Maybe the solution is already there. [*]Have a look at our [B][URL='https://issues.team-mediaportal.com/issues/?jql=project%20%3D%20MP2%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC']Jira (Bug and Issue Tracker)[/URL][/B]and the threads in this section, maybe your problem is already known. [*]Search the forums for your problem, it's very likely that someone else already encountered the same problem. [/LIST] [B][I][COLOR=rgb(243, 121, 52)]Please always include log files with your Bug Report![/COLOR][/I][/B] Check out our Wiki: [URL='https://www.team-mediaportal.com/wiki/display/MediaPortal2/Bug+Reports+and+Log+Files'][B]Bug Reports and Log Files[/B][/URL] ================================================================== [SIZE=3][I]Describe the Problem you encounter as detailed as possible! "It does not work" won't help the team to understand the problem. [/I][/SIZE] [B] Description: [/B] I noticed on github.com that in [B]MediaPortal-2/MediaPortal/Source/UI/Players/RefreshRateChanger/RefreshRateChanger.cs[/B], there seems to be an assumption that the source and target of each path will appear at adjacent indices in _modeInfoArray, e.g. around [B]line 402[/B]: [CODE]402: var modeIndex = _displayIndex * 2; // Array always contains "Source" and "Target" per display[/CODE] This is generally true, but [I]not always[/I]. Specifically, when a display is configured to duplicate another display (rather than extend the desktop). For example, with three GDI displays mapped to three different monitors, you'll get this from [ICODE]QueryDisplayConfig()[/ICODE]: [FONT=courier new] PathIdx | SrcModeIdx | TgtModeIdx ---------+------------+------------ 0 | 1 | 0 1 | 3 | 2 2 | 5 | 4[/FONT] ...but if you set the second monitor to duplicate the first (primary) display, you get this: [FONT=courier new] PathIdx | SrcModeIdx | TgtModeIdx ---------+------------+------------ 0 | 1 | 0 1 | [B]1[/B] | 2 2 | [B]4[/B] | [B]3[/B][/FONT] Note that the duplicating display also messes up the [target, source] ordering assumed by the current code. You should be able to confirm this by testing on a system with multiple monitors (two or more), and using [B]Display settings[/B] to configure the second display to Duplicate the first (primary) display. If you then run the RefreshRateChanger code, you should see an issue. Sorry I don't just submit an MR myself, but I'm not a regular contributor; just happened to spot this while browsing and thought you'd want to know. -MrINTJ [I][SIZE=3]Describe as detailed as possible the steps that are required to encounter the issue. This info is critical for the team to understand the problem. [/SIZE][/I] [B] Steps to Reproduce: [/B] . [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Submit: Bug Reports
Design issue? Assumption in code doesn't seem to be true...
Contact us
RSS
Top
Bottom