home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Submit: Bug Reports
Design issue? Assumption in code doesn't seem to be true...
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="Brownard" data-source="post: 1284778" data-attributes="member: 48291"><p>[USER=167880]@MrINTJ[/USER] [USER=48495]@morpheus_xx[/USER] I have pushed changes to <a href="https://github.com/MediaPortal/MediaPortal-2/tree/MP2-877_Improve_refresh_rate_changer_display_selection" target="_blank">MP2-877_Improve_refresh_rate_changer_display_selection</a>.</p><p>Previously we were assuming the ordering of Forms.AllScreens was equivalent to the ordering of the display info returned in QueryDisplayConfig in addition to the assumptions of the ordering of the mode infos pointed out above. I expect this assumption is generally true but not guaranteed as the results of QueryDisplayConfig can change when the screen configuration changes, whereas the Forms.AllScreens array is created once when first referenced and not updated after that. What I've done instead is <a href="https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-7ffc1847fc29cb77a20a4e62c8b8490c3c87248a1bf69da1fe3476dda20f2c74R56" target="_blank">use the DeviceName of the current forms screen</a>, then this can be <a href="https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-9693bfaf428f8b27077454bb606fe77c54ab7f95f31599e754a85e12092240a8R644" target="_blank">mapped to a device interface name through EnumDisplayDevices</a>, then the path infos returned by QueryDisplayConfig <a href="https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-9693bfaf428f8b27077454bb606fe77c54ab7f95f31599e754a85e12092240a8R606" target="_blank">can be matched against this interface name to get the correct mode index</a>.</p><p></p><p>I don't have multiple monitors to test properly, and I'm no expert on Windows display configuration, so this could do with some review and testing <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin :D" loading="lazy" data-shortname=":D" /></p></blockquote><p></p>
[QUOTE="Brownard, post: 1284778, member: 48291"] [USER=167880]@MrINTJ[/USER] [USER=48495]@morpheus_xx[/USER] I have pushed changes to [URL='https://github.com/MediaPortal/MediaPortal-2/tree/MP2-877_Improve_refresh_rate_changer_display_selection']MP2-877_Improve_refresh_rate_changer_display_selection[/URL]. Previously we were assuming the ordering of Forms.AllScreens was equivalent to the ordering of the display info returned in QueryDisplayConfig in addition to the assumptions of the ordering of the mode infos pointed out above. I expect this assumption is generally true but not guaranteed as the results of QueryDisplayConfig can change when the screen configuration changes, whereas the Forms.AllScreens array is created once when first referenced and not updated after that. What I've done instead is [URL='https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-7ffc1847fc29cb77a20a4e62c8b8490c3c87248a1bf69da1fe3476dda20f2c74R56']use the DeviceName of the current forms screen[/URL], then this can be [URL='https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-9693bfaf428f8b27077454bb606fe77c54ab7f95f31599e754a85e12092240a8R644']mapped to a device interface name through EnumDisplayDevices[/URL], then the path infos returned by QueryDisplayConfig [URL='https://github.com/MediaPortal/MediaPortal-2/commit/b986d337c7f7e4b1983619f361e472e7831219aa#diff-9693bfaf428f8b27077454bb606fe77c54ab7f95f31599e754a85e12092240a8R606']can be matched against this interface name to get the correct mode index[/URL]. I don't have multiple monitors to test properly, and I'm no expert on Windows display configuration, so this could do with some review and testing :D [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Submit: Bug Reports
Design issue? Assumption in code doesn't seem to be true...
Contact us
RSS
Top
Bottom