Reply to thread

Message

<blockquote data-quote="jameson_uk" data-source="post: 587359" data-attributes="member: 11220">Yes.... that is why I don't use WMP <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />I have looked through the code a fair bit and in essence the problem is that there are folders in the thumbs directory for Artists and Albums.&nbsp; Both last.fm and music plugins use the same folders.&nbsp;&nbsp; There does appear to be some checking in the code that the new picture is better than the last one but I am not sure that is working...What this means is that if you have the option left as enabled then last.fm (and music) can replace your thumbs.&nbsp; I think there may be a bug with the album art anyway as it looks like it may download a 120x120 thumb and then expand this to 500x500 which is why it can look so bad...Unfortunately I can not really see a simple solution to this.&nbsp;&nbsp; There is simply a swtich in the music code based on this flag which if it is not disabled calls some code in the AudioScrobblerUtils class.&nbsp; last.fm however just makes the calls and the checking is done within the actual call to get thumbs....Ideally a new tickbox for last.fm and music would be the ideal solution but we can not just add a new config option as they share the same thumb directories...&nbsp; Even if they didn't, you would want last.fm to use any ones that were already downloaded and then cache a tmp set of images for now-playing...&nbsp;&nbsp; so it starts to get messy <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite4" alt=":mad:" title="Mad&nbsp; &nbsp; :mad:" loading="lazy" data-shortname=":mad:" />The other option would be to not let dynamic content overwrite local content (ie. last.fm could not replace local tagged or folder.jpg).&nbsp;&nbsp; This however can't be done as all thumbs are just stored as thumbs in the directory and once it gets there you do not know where it came from...I am going to think about this some more...</blockquote>

[QUOTE="jameson_uk, post: 587359, member: 11220"] Yes.... that is why I don't use WMP :P I have looked through the code a fair bit and in essence the problem is that there are folders in the thumbs directory for Artists and Albums. Both last.fm and music plugins use the same folders. There does appear to be some checking in the code that the new picture is better than the last one but I am not sure that is working... What this means is that if you have the option left as enabled then last.fm (and music) can replace your thumbs. I think there may be a bug with the album art anyway as it looks like it may download a 120x120 thumb and then expand this to 500x500 which is why it can look so bad... Unfortunately I can not really see a simple solution to this. There is simply a swtich in the music code based on this flag which if it is not disabled calls some code in the AudioScrobblerUtils class. last.fm however just makes the calls and the checking is done within the actual call to get thumbs.... Ideally a new tickbox for last.fm and music would be the ideal solution but we can not just add a new config option as they share the same thumb directories... Even if they didn't, you would want last.fm to use any ones that were already downloaded and then cache a tmp set of images for now-playing... so it starts to get messy :wtf: The other option would be to not let dynamic content overwrite local content (ie. last.fm could not replace local tagged or folder.jpg). This however can't be done as all thumbs are just stored as thumbs in the directory and once it gets there you do not know where it came from... I am going to think about this some more... [/QUOTE]

Verification