Reply to thread

Message

<blockquote data-quote="herluf" data-source="post: 406755" data-attributes="member: 89810">Hi - I have been looking at this, since i usually play my music from cd's. The first time a cd is inserted everything plays well, but the next time a cd is inserted it seems a new deviceVolumeMonitor is created and the old one is still listening, so there are now two monitors receiving the &quot;insert&quot; event. The 3rd time a cd is inserted two more monitors are created and so 4 monitors now receive the &quot;insert&quot; event, and so on...The only thing changed as far as i can tell is the following in the Dispose method of DeviceVolumeMonitor.cs:&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // handle should not be released as this is the handle for MediaPortal itself (just borrowing &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // it for wndproc message purposes). Just nulling the reference and letting the garbage collector&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // clean up is enough to free resources for device monitoring.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //fInternal.ReleaseHandle();Instead fInternal is just set = null. As mentioned the garbage collector should remove the monitor, but it seems this doesn't happen. I tried setting DeviceMonitor.Enabled = false; instead of calling dispose from Autoplay.cs and that works (at least for cd's haven't tried dvd's). Enabled = false, calls the releaseHandle by the way. I'm not sure if the correct solution would be to set Enabled = false in the Dispose method just before setting the fInternal = null, but this is just a heads up to anyone willing to correct this or knows how to submit a patch.</blockquote>

[QUOTE="herluf, post: 406755, member: 89810"] Hi - I have been looking at this, since i usually play my music from cd's. The first time a cd is inserted everything plays well, but the next time a cd is inserted it seems a new deviceVolumeMonitor is created and the old one is still listening, so there are now two monitors receiving the "insert" event. The 3rd time a cd is inserted two more monitors are created and so 4 monitors now receive the "insert" event, and so on... The only thing changed as far as i can tell is the following in the Dispose method of DeviceVolumeMonitor.cs: // handle should not be released as this is the handle for MediaPortal itself (just borrowing // it for wndproc message purposes). Just nulling the reference and letting the garbage collector // clean up is enough to free resources for device monitoring. //fInternal.ReleaseHandle(); Instead fInternal is just set = null. As mentioned the garbage collector should remove the monitor, but it seems this doesn't happen. I tried setting DeviceMonitor.Enabled = false; instead of calling dispose from Autoplay.cs and that works (at least for cd's haven't tried dvd's). Enabled = false, calls the releaseHandle by the way. I'm not sure if the correct solution would be to set Enabled = false in the Dispose method just before setting the fInternal = null, but this is just a heads up to anyone willing to correct this or knows how to submit a patch. [/QUOTE]

Verification