Reply to thread

Message

<blockquote data-quote="tourettes" data-source="post: 407848" data-attributes="member: 10858">There are two different issues:#1 device monitor instances aren't cleaned properly[code]StopListeningForEvents()should have&nbsp; &nbsp; &nbsp; &nbsp; _deviceMonitor.OnVolumeInserted -= new DeviceVolumeAction(VolumeInserted);&nbsp; &nbsp; &nbsp; &nbsp; _deviceMonitor.OnVolumeRemoved -= new DeviceVolumeAction(VolumeRemoved);[/code]#2 DeviceVolumeMonitor objects aren't disposed (GC won't remove those when the handle is not released by fInternal.ReleaseHandle();1st one is easy to fix (this will slow down the system resource leaking as it will not leak the resources in power of two...) but the 2nd one is nasty as the previos fix was done to cure some bug with music visualization and Moving Pictures plugin (if I remember correctly).DeviceMonitor.Enabled = false; is doing the same as the commented code i.e. releasing the handle.</blockquote>

[QUOTE="tourettes, post: 407848, member: 10858"] There are two different issues: #1 device monitor instances aren't cleaned properly [code] StopListeningForEvents() should have _deviceMonitor.OnVolumeInserted -= new DeviceVolumeAction(VolumeInserted); _deviceMonitor.OnVolumeRemoved -= new DeviceVolumeAction(VolumeRemoved); [/code] #2 DeviceVolumeMonitor objects aren't disposed (GC won't remove those when the handle is not released by fInternal.ReleaseHandle(); 1st one is easy to fix (this will slow down the system resource leaking as it will not leak the resources in power of two...) but the 2nd one is nasty as the previos fix was done to cure some bug with music visualization and Moving Pictures plugin (if I remember correctly). DeviceMonitor.Enabled = false; is doing the same as the commented code i.e. releasing the handle. [/QUOTE]

Verification