Reply to thread

Message

<blockquote data-quote="Disore" data-source="post: 744041" data-attributes="member: 89076">I've tracked down my problem, and it is a bug.In class PackageClass we have the following code:[CODE]/// &lt;summary&gt;/// Do the unistall procces. The unistall file info should be alredy loaded./// &lt;/summary&gt;public void UnInstall(){&nbsp; for (int i = UnInstallInfo.Items.Count - 1; i &gt; 0; i--)&nbsp; {&nbsp; &nbsp; UnInstallItem item = UnInstallInfo.Items[i];&nbsp; &nbsp; if (string.IsNullOrEmpty(item.ActionType))&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; MpeInstaller.InstallerTypeProviders[item.InstallType].Uninstall(this, item);&nbsp; &nbsp; &nbsp; if (FileUnInstalled != null)&nbsp; &nbsp; &nbsp; &nbsp; FileUnInstalled(this, new UnInstallEventArgs(&quot;Removing file &quot; + Path.GetFileName(item.OriginalFile), item));&nbsp; &nbsp; }&nbsp; &nbsp; else&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; MpeInstaller.ActionProviders[item.ActionType].UnInstall(this, item);&nbsp; &nbsp; &nbsp; if (FileUnInstalled != null)&nbsp; &nbsp; &nbsp; &nbsp; FileUnInstalled(this, new UnInstallEventArgs(&quot;Removing action &quot; + item.ActionType, item));&nbsp; &nbsp; }&nbsp; }&nbsp; UnInstallInfo.Items.Clear();&nbsp; DoAdditionalUnInstallTasks();}[/CODE]The problem is that the first file with index == 0 won't be uninstalled since 'i &gt; 0' is stated in the for-loop. Dukus, can you fix this? Or else I volunteer to fix it if given the correct permissions. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />It won't help me since I've already released a second version of my plugin, and the leftover file from uninstalling the first version will be cached by MPE when installing the second version, but it may help new plugin developers.</blockquote>

[QUOTE="Disore, post: 744041, member: 89076"] I've tracked down my problem, and it is a bug. In class PackageClass we have the following code: [CODE]/// <summary> /// Do the unistall procces. The unistall file info should be alredy loaded. /// </summary> public void UnInstall() { for (int i = UnInstallInfo.Items.Count - 1; i > 0; i--) { UnInstallItem item = UnInstallInfo.Items[i]; if (string.IsNullOrEmpty(item.ActionType)) { MpeInstaller.InstallerTypeProviders[item.InstallType].Uninstall(this, item); if (FileUnInstalled != null) FileUnInstalled(this, new UnInstallEventArgs("Removing file " + Path.GetFileName(item.OriginalFile), item)); } else { MpeInstaller.ActionProviders[item.ActionType].UnInstall(this, item); if (FileUnInstalled != null) FileUnInstalled(this, new UnInstallEventArgs("Removing action " + item.ActionType, item)); } } UnInstallInfo.Items.Clear(); DoAdditionalUnInstallTasks(); }[/CODE] The problem is that the first file with index == 0 won't be uninstalled since 'i > 0' is stated in the for-loop. Dukus, can you fix this? Or else I volunteer to fix it if given the correct permissions. :) It won't help me since I've already released a second version of my plugin, and the leftover file from uninstalling the first version will be cached by MPE when installing the second version, but it may help new plugin developers. [/QUOTE]

Verification