Reply to thread

Message

<blockquote data-quote="Inker" data-source="post: 573755" data-attributes="member: 10541">Well, there certainly are legitimate uses for running them after. the running after tag can be used excelletely to &quot;smuggle&quot; things by the parser (such as filenames with &quot;sample&quot; in there somehow, or consider a show named &quot;Math 101&quot;. An episode might then be named &quot;Math 101 - S01E01 - Additions.avi&quot;. The parser might take the 101 as indicating season-episode, it certainly fits the pattern. If you have single regex's you can reorder the SxEx one above the one looking for SEE, however its easier to first replace &quot;Math 101&quot; with something like &quot;Math &lt;oneohone&gt;&quot; and after the regex parser put it back correctly.The performance aspect you talk about isn't as clear cut btw. If you have alot of files in your watched dirs that don't match then certainly alot of pre-parser replacements will take its toll, however, if that is not the case then pre-parsing expressions should in theory be faster, because while they have to run on a bigger string (the entire filename), they only need to be run once, as apposed to once per capture group the regex returns. Believe me I spent hours upon hours perf-tuning the local import process ages ago. In either case, perf really shouldn't play a role here, file listing is really the bottleneck, especially over the lan.I still don't understand the need for for string replacements after you explained it, it seems to me the addition of the string replacement per wrongly named series requires at least the same amount of &quot;work&quot; as the one time correction during the import process. Except with the former you eventually end up with dozens of series-name string replacement to the point that it might just become a factor of slowdown.Certainly if you feel this is the best way to handle wrong series then there is a design issue in the plugin and this should be discussed further to find a proper solution.BTW the only reason I corrected you was because you seemed to make it especially importatnt that this setting needed to be set.</blockquote>

[QUOTE="Inker, post: 573755, member: 10541"] Well, there certainly are legitimate uses for running them after. the running after tag can be used excelletely to "smuggle" things by the parser (such as filenames with "sample" in there somehow, or consider a show named "Math 101". An episode might then be named "Math 101 - S01E01 - Additions.avi". The parser might take the 101 as indicating season-episode, it certainly fits the pattern. If you have single regex's you can reorder the SxEx one above the one looking for SEE, however its easier to first replace "Math 101" with something like "Math <oneohone>" and after the regex parser put it back correctly. The performance aspect you talk about isn't as clear cut btw. If you have alot of files in your watched dirs that don't match then certainly alot of pre-parser replacements will take its toll, however, if that is not the case then pre-parsing expressions should in theory be faster, because while they have to run on a bigger string (the entire filename), they only need to be run once, as apposed to once per capture group the regex returns. Believe me I spent hours upon hours perf-tuning the local import process ages ago. In either case, perf really shouldn't play a role here, file listing is really the bottleneck, especially over the lan. I still don't understand the need for for string replacements after you explained it, it seems to me the addition of the string replacement per wrongly named series requires at least the same amount of "work" as the one time correction during the import process. Except with the former you eventually end up with dozens of series-name string replacement to the point that it might just become a factor of slowdown. Certainly if you feel this is the best way to handle wrong series then there is a design issue in the plugin and this should be discussed further to find a proper solution. BTW the only reason I corrected you was because you seemed to make it especially importatnt that this setting needed to be set. [/QUOTE]

Verification