Reply to thread

Message

<blockquote data-quote="RoChess" data-source="post: 1272744" data-attributes="member: 18896">The TMDb scraper-script in Moving-Pictures is a C# based one, and not XML, due to the way TMDb works with the API key it needs.Feel free to make modifications to it @ <a href="https://github.com/damienhaynes/moving-pictures/blob/master/MovingPictures/DataProviders/TheMovieDbProvider.cs" target="_blank">https://github.com/damienhaynes/moving-pictures/blob/master/MovingPictures/DataProviders/TheMovieDbProvider.cs</a>For that to become part of the public release you'll have to create a pull request.PS: Keep in mind that when you make modifications to not just think &quot;this is how I want it&quot;, but to also consider how others might want it, and add advanced configuration options to adjust behavior based on preference. That's why IMDb+ ballooned so quickly because it can become a nightmare to accommodate everybody <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite11" alt=":rolleyes:" title="Roll Eyes&nbsp; &nbsp; :rolleyes:" loading="lazy" data-shortname=":rolleyes:" />PPS: So, pseudo code style you get something like this:[code]// add genresif (movieDetails.Genres != null) {&nbsp;&nbsp; movie.Genres.AddRange(movieDetails.Genres.Select(g =&gt; g.Name).ToArray());&nbsp;&nbsp; if (MovingPicturesCore.Settings.FixGermanGenres) {&nbsp; &nbsp; &nbsp;&nbsp; // fixing Genres&nbsp; &nbsp; &nbsp;&nbsp; // adjust &quot;Liebesfilm&quot; into &quot;Liebe &amp; Romantik&quot;, etc.&nbsp; &nbsp; &nbsp;&nbsp; // might need to expose another advanced config option to allow custom replacement, seem to recall there is another option like that, so you can duplicate syntax.&nbsp;&nbsp; }}[/code]</blockquote>

[QUOTE="RoChess, post: 1272744, member: 18896"] The TMDb scraper-script in Moving-Pictures is a C# based one, and not XML, due to the way TMDb works with the API key it needs. Feel free to make modifications to it @ [URL='https://github.com/damienhaynes/moving-pictures/blob/master/MovingPictures/DataProviders/TheMovieDbProvider.cs'][B]https://github.com/damienhaynes/moving-pictures/blob/master/MovingPictures/DataProviders/TheMovieDbProvider.cs[/B][/URL] For that to become part of the public release you'll have to create a pull request. PS: Keep in mind that when you make modifications to not just think "this is how I want it", but to also consider how others might want it, and add advanced configuration options to adjust behavior based on preference. That's why IMDb+ ballooned so quickly because it can become a nightmare to accommodate everybody :rolleyes: PPS: So, pseudo code style you get something like this: [code] // add genres if (movieDetails.Genres != null) { movie.Genres.AddRange(movieDetails.Genres.Select(g => g.Name).ToArray()); if (MovingPicturesCore.Settings.FixGermanGenres) { // fixing Genres // adjust "Liebesfilm" into "Liebe & Romantik", etc. // might need to expose another advanced config option to allow custom replacement, seem to recall there is another option like that, so you can duplicate syntax. } } [/code] [/QUOTE]

Verification