[Approved] Filmstrip OnRight and OnDown do not work (1 Viewer)

[mpiva]

OnRight and OnDown action are not executed on filmstrip.

This patch will enable them when spinCanFocus is false



Also on OnLeft there is this fragment of code on v1.4.0 MASTER:

		  if (_upDownControl != null && _spinCanFocus)
		  {
			_upDownControl.Focus = true;
		  }
		  else
		  {
			_listType = GUIListControl.ListType.CONTROL_LIST;
			this.Focus = true;
			base.OnAction(action);
		  }

Please check if the funcionality is desired (Keep pressing left, will jump to the updown button, or execute OnLeft if updown button cannot be focused). If the funcionality is the desired one, same functionality should be added in OnRight.

 

[Holzi]

I noticed that OnDown is not working and did a workaround myself. Never tested OnRight. Will do soon. Thanks for your patch!

@Sebastiii could you create a branch with this so we could test? Would be very nice!

 

[Sebastiii]

Could you create Jira ticket ?
Thanks

 

[elliottmc]

Bump!!!

 

[Sebastiii]

Will try to create a branch based on the atached path in first post, but not right now

 

[elliottmc]

Thanks. Just didn't want it to get lost

 

[Sebastiii]

Do we have a Jira entry for this ? (i didn't find it lol)

 

[Holzi]

Do we have a Jira entry for this ? (i didn't find it lol)

We have one for OnDown: https://issues.team-mediaportal.com/browse/MP1-2412
I forgot to test if OnRight doesn't work too so I can not confirm this atm, but we could easiliy rename the Jira entry?

 

[elliottmc]

Do we have a Jira entry for this ? (i didn't find it lol)

We have one for OnDown: https://issues.team-mediaportal.com/browse/MP1-2412
I forgot to test if OnRight doesn't work too so I can not confirm this atm, but we could easiliy rename the Jira entry?

Could you take care of this?

 

[Holzi]

In this entry I stated that OnRight works. Will have to double check since it has been awhile.