[Approved] - Filmstrip OnRight and OnDown do not work

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by mpiva, June 25, 2013.

  1. mpiva

    mpiva Portal Member

    Joined:
    June 29, 2009
    Messages:
    20
    Likes Received:
    4
    Ratings:
    +4 / 0
    Home Country:
    OnRight and OnDown action are not executed on filmstrip.

    This patch will enable them when spinCanFocus is false



    Also on OnLeft there is this fragment of code on v1.4.0 MASTER:

    Code (Text):
    1.           if (_upDownControl != null && _spinCanFocus)
    2.           {
    3.             _upDownControl.Focus = true;
    4.           }
    5.           else
    6.           {
    7.             _listType = GUIListControl.ListType.CONTROL_LIST;
    8.             this.Focus = true;
    9.             base.OnAction(action);
    10.           }
    Please check if the funcionality is desired (Keep pressing left, will jump to the updown button, or execute OnLeft if updown button cannot be focused). If the funcionality is the desired one, same functionality should be added in OnRight.


     

    Attached Files:

    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    I noticed that OnDown is not working and did a workaround myself. Never tested OnRight. Will do soon. Thanks for your patch!

    @Sebastiii could you create a branch with this so we could test? Would be very nice! :)
     
    Last edited: June 25, 2013
  4. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,296
    Likes Received:
    6,248
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,269 / 9
    Home Country:
    France France
    Show System Specs
    Could you create Jira ticket ? :)
    Thanks
     
  5. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,296
    Likes Received:
    6,248
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,269 / 9
    Home Country:
    France France
    Show System Specs
    Will try to create a branch based on the atached path in first post, but not right now :)
     
  7. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Thanks. Just didn't want it to get lost
     
    • Like Like x 1
  8. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,296
    Likes Received:
    6,248
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,269 / 9
    Home Country:
    France France
    Show System Specs
    Do we have a Jira entry for this ? (i didn't find it lol)
     
  9. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs

    We have one for OnDown: https://issues.team-mediaportal.com/browse/MP1-2412 :)
    I forgot to test if OnRight doesn't work too so I can not confirm this atm, but we could easiliy rename the Jira entry?
     
    • Like Like x 1
  10. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Could you take care of this?
     
    • Like Like x 1
  11. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    In this entry I stated that OnRight works. Will have to double check since it has been awhile.
     
    • Thank You! Thank You! x 1
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!