[Approved] Filmstrip thumbZoom and image-alignment (1 Viewer)

[pilehave]

Problem:
thumbZoom is not enabled for filmstrip. This gives a skinner only two ways to display mixed landscape and portrait pictures:

Option 1, keepaspectratio=no

Advantage=aspectratio is kept, disadvantage=image is zoomed and not shown entirely

Option 2, keepaspectratio=yes

Advantage=whole image is shown, disadvantage=aspectratio disturbed

New option, thumbZoom

Advantage=image is not zoomed and aspectratio is kept, disadvantage=does not fill the frame

When I enabled keepaspectratio for Coverflow I was asked to add support for thumbZoom as well, as this is way more useful.

I also added two new properties to align the thumb vertically and horizontally.

Now I have done the same for filmstrip:

3 new properties have been added:

    [XMLSkinElement("thumbZoom")] protected bool _zoom = false;
    [XMLSkinElement("thumbAlign")] protected Alignment _imageAlignment = Alignment.ALIGN_CENTER;
    [XMLSkinElement("thumbVAlign")] protected VAlignment _imageVAlignment = VAlignment.ALIGN_BOTTOM;

If this a feature that may be added for 1.2.0 RC or later, then that is fine with me. I just wanted to complete the circle, since we now have thumbZoom for thumbs and coverflow already...

Patch against SVN 27537 attached.

 

[ajp8164]

Hi pilehave,

Is this enhancement something that should still be considered? If so, we'll need to create a git branch and mantis entry for it..

Thanks!

 

[pilehave]

Hi pilehave,

Is this enhancement something that should still be considered? If so, we'll need to create a git branch and mantis entry for it..

Thanks!

Yes, I hope that this will still make into MP at some point. I pretty much gave up on MP development when the swich to GIT was made. I find it utterly confusing to work with

 

[jameson_uk]

Not sure why we make things difficult for ourselves
http://mantis.team-mediaportal.com/view.php?id=3847
FEAT_3487_thumbZoom_Alignment_filmstrip branch in GIT

 

[offbyone]

Reviewed, tested and no error found here. Committed to 1.3 Alpha testing branch.