[Approved] Fix for Mantis 2866: Visiblechange animations not processing reverse animations (1 Viewer)

[Migue]

This patch addresses 0002866: Visiblechange animations do not process reverse animations correctly - MediaPortal Bugtracker.

MP currently has no implementation for visiblechange animations. As a result they are processed exactly the same as a visible animation.

This patch creates a corresponding Hidden animation with values reversed.

Skins that have used a visiblechange animation in place of a visible animation will need to change the animation type. Previously it did not matter, but with this patch the hidden animation will now be processed as well.

The default value for a visiblechange animation is reversible='true' to match the default of a visible animation This means that if the animation is interrupted before it has completed processing, it will reverse the animation rather than just halt it (reversible=false)

NOTE: This patch will make the hidden animation bug 0002867: Hidden animations all execute on windowopen - MediaPortal Bugtracker even more apparent. Please see my patch for Fix for Mantis 2867 : Hidden animations all execute on windowopen which addresses this Mantis issue.

I have attached a patch for this fix only, for code review. I have also attached a binary (core.dll) with both patches integrated, for test purposes.

 

[Bavarian]

for your patch

it is implemented in SVN 26511

 

[mironicus]

AW: Fix for Mantis 2866: Visiblechange animations not processing reverse animations

It seems that skins indeed have to be modified due to this new added code. Using Black Glass I now see various mixed overlays / animations that I never saw before with this patch. Also with Blue 3 Wide I now see some annoying little overlays / flashing for some milliseconds after starting / stopping a video.

 

[DieBagger]

Hi, I suppose this change is the reason for breaking the streamedmp basichome (see screenshot)?

 

[Dadeo]

Are you all using the binary or the patch? As Migue clearly stated in the first post:

NOTE: This patch will make the hidden animation bug 0002867: Hidden animations all execute on windowopen - MediaPortal Bugtracker even more apparent. Please see my patch for Fix for Mantis 2867 : Hidden animations all execute on windowopen which addresses this Mantis issue.

however that patch has not yet been comitted to SVN. So if you are using latest SVN then until the second patch is committed you will have these problems. Skins should not make any changes until both patches have been committed.

 

[catavolt]

AW: Fix for Mantis 2866: Visiblechange animations not processing reverse animations

Hmm, strange indeed...
EDIT: Doug, we were posting at the same time.

 

[Bavarian]

second patch will follow tomorrow

 

[DieBagger]

I was using the latest svn (without patch), I was under the impression that the patch had been already commited...

Will test again tomorrow...

 

[Bavarian]

second patch is in SVN
please try again

 

[Dadeo]

Thanks Bavarian, but everyone should please keep in mind that skins may require some modificaions. Mainly because animations never worked correctly before, and because many skins developed workarounds for the hidden animations not working properly.

Also skinners have been able to use visiblechange incorrectly because it just worked like a visible animation, so those will need to be corrected before skins will be perfect again. In most cases, only minor changes are required to skins, but we need to give skinners a bit of time to implement the changes.