[Evaluate] Fix RTL text scrolling (1 Viewer)

bob987

MP Donator
  • Premium Supporter
  • January 25, 2009
    47
    5
    Israel Israel
    This patch fixes some of the problems concerning the scrolling of text with right to left characters in it.

    Currently RTL text scrolls in a very strange way (see Strange Hebrew text scroll )
    With this patch the RTL text will scroll continually to the right in a smooth way without jumping.

    This bug fix will improve all the RTL language users UI Experience



    There is still some work to be done concerning the RTL scrolling:
    A) In mixed text (LTR & RTL) when a new LTR word appears its characters will appear in the wrong order ("hello" will not appear h->e->l->l->o but o->l->l->e->h). This also the case with the current text scrolls.

    B) When the RTL scrolling text appears, the right most part of the text is already trimmed from the screen. The text should appear with its right most part aligned to the right side of the text box.

    C) RTL scrolling text should have the fade effect in the left side of the text box.
    I will try to solve A in the future. B+C are probably over my ability.

    Hope this will get into RC2,
    Bob
     

    Attachments

    bob987

    MP Donator
  • Premium Supporter
  • January 25, 2009
    47
    5
    Israel Israel
    Probably most of the dev guys don’t have a system with RTL language installed, so I made two short avi to let you see the bug and the fix.
    There are 3 scrolling texts:
    a) Only LTR.
    b) RTL + LTR
    c) Only RTL
    Movie recorded using horizontal scroll speed=4

    Bob
     

    Attachments

    bob987

    MP Donator
  • Premium Supporter
  • January 25, 2009
    47
    5
    Israel Israel
    I've updated the patch to RC2 (no changes in the code) for my own use so I send the updated file.

    Is there some thing I can do to help this get into the next release?

    Bob
     

    Attachments

    elliottmc

    Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    Hi,

    I can't test this myself, but from the videos provided, it seems that it would be good to include it.

    Perhaps one of the developers could build binaries for testing?

    As long as it doesn't cause any problems, it is probably safe to commit.

    Mark
     

    thecode

    Portal Member
    March 4, 2011
    9
    6
    Israel Israel
    I've tried to test it with the SVN version r27641 but for some reason live TV stopped working for me (some index out of bounds)
    The patch does solve the scrolling bug, Since I've done some changes to my version also and had to merge files might be problem on my side.
    I'll try over the weekend to do clean patch on the latest SVN and publish my conclusions.

    thecode
     

    thecode

    Portal Member
    March 4, 2011
    9
    6
    Israel Israel
    I tried testing the patch, it does work, but I'm sad to say it doesn't fix all situations.
    If the test has mixed RTL text and LTR text it will not scroll correctly at all.
    In mixed text it should scroll as it has only RTL text.
    I hope to have time to fix that, but if it is not fixed I suggest waiting with the patch (Altought is still fix some situations and doesn't cause problems).

    thecode.
     

    bob987

    MP Donator
  • Premium Supporter
  • January 25, 2009
    47
    5
    Israel Israel
    Hi
    I know that this code only fixes RTL only texts.
    I tried to fix the mixed text situation but to do this there is a need to rewrite all the text handling code (which is over my capabilities).
    I do think that this patch will improve the current code and should be implemented in V1.2

    For V2, it will be a big improvement to use the internal window API for text printing. there is a very complex logic with mixed LTR + RTL text, and windows does a great job in this area.

    Bob
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    framug [solved] Some changes/fix in MP1 configuration client and server Submit: code patches (MediaPortal/TV-Server/etc.) 14
    framug [Approved] Fix Irtrans config bug Submit: code patches (MediaPortal/TV-Server/etc.) 4
    W [solved] [FIXED] Survivor season 40 not automatically matching My TVSeries 1
    P [solved] ATSC subtitles not fixed yet? General 2
    framug [Rejected] Fix PowerScheduler plugin for MP2 single seat Submit: Code Patches 9
    M [Pending] Fix for Inconsistent date display in TV Guide Submit: code patches (MediaPortal/TV-Server/etc.) 1
    doskabouter [Proposal] Merge PR Fix for source directory with spaces MediaPortal 1 15
    CyberSimian Fixes for Amped aMPed 5
    CyberSimian Fixes for Amped skin MediaPortal 1 10
    J Kein Rtl, Sat 1 Pro 7 ... mehr TV / Streaming 0
    W Keine SD Sender mehr wie Pro 7, SAT 1 RTL Allgemeines Support- und Diskussionsforum 4
    N HD Channels of RTL Channel Group not working anymore Television (MyTV frontend and TV-Server) 6
    N HD Sender der RTL Gruppe (HD+) werden nicht mehr wiedergegeben TV / Streaming 0
    123vak123 [solved] 5008: The problem with scrolling text in the "listcontrol" in 4K General Support 22
    wizard123 [solved] Auto sizing buttons to text content MediaPortal 1 11
    B Text files attached to videos Watch / Listen Media 10
    N [Proposal] Make text input using remote control easier MediaPortal 2 4
    N [Proposal] Make text input possible with remote control in SMS style MediaPortal 2 1
    azzuro [solved] GIT Commit text to be captured by Jira MediaPortal 2 13
    N How to input text with the remote control General 3
    N Input import directories via text? My TVSeries 6
    zunixnuz TV Mini-EPG long text cropped on bottom side Titan Skin Feedback 0
    M partially watched video/song/recorded tv show file text color + remember cursor in folders other features (of release or svn versions) 28
    Similar threads























    Top Bottom