[Approved] Fix string functions (skin) getting re-evaluated every render pass (1 Viewer)

[disaster123]

AW: Fix string functions (skin) getting re-evaluated every render pass

nice patch - but any chance to get the + thing chemilli mentioned fixed? Would be nice to see this in MP 1.1.0

 

[Pog]

Very nice, working great so far.

I have a very fast system and this clears up the scrolling lag nicely.

 

[Zinu]

As said before, great patch. Really speeds up scrolling alot! Now it's *almost* just as smooth as MyTVseries

 

[Dr Tone]

I've been running this patch without issue, I hope it makes it into RC2.

 

[Sebastiii]

Hi,
I'll test in RC2, and CPU usage goes to down Great

 

[armandp]

As said before, great patch. Really speeds up scrolling alot! Now it's *almost* just as smooth as MyTVseries

we are not on the moving pictures forum this is the general mediaportal patch section

 

[gibman]

You should probably use Dictionary.TryGetValue instead of Dictionary.Contains, whenever you use ".contains" to later actually retrieving the value.

more info here.
C# Dictionary Lookup Comparison

Otherwise it looks ok to me.

/gibman

 

[chemelli]

Commited to svn25209

a lot Armand

Simone

 

[armandp]

thnx for the tip and benchmarks gibman. I was under the false impression gettryvalue involved some hidden exception catching but that's not the case with dictionary. I will update this patch (and my other one) by the end of next week. We can use every speed increase we can gain as this is mostly called in the render logic.

nice patch - but any chance to get the + thing chemilli mentioned fixed? Would be nice to see this in MP 1.1.0

I already looked into that issue and i think i can come up with a solution this weekend (as i'm on holiday right now)