[Approved] flipX does not work (1 Viewer)

[mrj]

Hi

There is a cut and paste bug in GUIAnimation.cs
line 292

code below

_images[index].MaskFileName = _maskFileName;
_images[index].FlipY = _flipX;
_images[index].FlipY = _flipY;

should be changed to

_images[index].MaskFileName = _maskFileName;
_images[index].FlipX = _flipX;
_images[index].FlipY = _flipY;

mrj

 

[Spragleknas]

Need a tester to confirm the problem and fix, but seems like a copy-paste error

 

[elliottmc]

Are we sure of this based on flipx not working, and it working with this change?

Could you provide a clear test scenario to confirm? I don't know enough about flipx to be certain of what to expect.

Mark

 

[Holzi]

For me flipX is working with or without the change.

    <control>
      <description>Default Category Image</description>
      <type>image</type>
      <id>0</id>
      <posX>150</posX>
      <posY>330</posY>
      <width>341</width>
      <height>341</height>
      <texture flipX="true" diffuse="Thumb_Mask.png">Categories\#MovingPictures.SelectedNode.FileFriendlyName.png</texture>
      <keepaspectratio>yes</keepaspectratio>
      <animation effect="fade" time="250">WindowOpen</animation>
      <animation effect="fade" time="250">WindowClose</animation>
      <visible>Control.IsVisible(51)+!Control.IsVisible(50)+!Control.HasThumb(100)</visible>
    </control>

Screenshot:

 

[elliottmc]

I have looked at the code, and it is in a fairly general routine, and really does look like a copy/paste error. Without being an expert, I am surprised that the code currently works (not that I am disputing you) and since it works with the change then I think it should be changed.

It would help if the OP could confirm in which situations this fails for him. However, he probably would not have spotted the code error if he hadn't seen a problem. Shame that he hasn't been on the forum for a while.

Mark

 

[Holzi]

Maybe some skin designer or developer (dadeo) could also test it without the fix. It is an easy change to a skin xml.. but I also don't know if I tested it the right way.

It really would be nice to hear from the OP again.

 

[mrj]

hi guys

I found the bug when I was playing with the hover images on the home screen.
so the maybe the bug only applies to the
<type>menu</type>
in myHome.xml

what I did was something like this:

<hover flipX = "true" diffuse = "Thumb_Mask.png"></hover>

which did not work.

HTH mrj

 

[Sebastiii]

Hi Mrj

And with the fix it's ok ? EDIT : i assume yes lol it's you that report the issue (sorry)
If yes we need to create a mantis and a branch for that
Seb.

 

[mrj]

Hi Seb
Yes, it works after the change.
mrj

 

[Holzi]

Nice!
Sebastiii: Could you create mantis + branch? =)