Reply to thread

Message

Problem is in enumeration of MP window id's. Because new GUI settings introduced new window names for better understanding (old names was not so clear), but not to break old naming system for 1.3.0 (in 1.4.0 old names will be removed) now exists few same window id's with different names (old one is marked in code as depreciated) which in this plugin causing exception because it takes one by one window id and as id is some kind of index it must be unique and we end on exception of already existing id.

So to skip those duplicates we must skip old windows in MPwindow enumeration with
case (int)GUIWindow.Window.WINDOW_SETTINGS_SCREEN:
case (int)GUIWindow.Window.WINDOW_SETTINGS_SLIDESHOW:
case (int)GUIWindow.Window.WINDOW_SETTINGS_GUI:
case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIN:
case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIPSTEPS:
continue;

@[USER=24295]rsenden[/USER] needs to take care of this in code and all will be ok after (but it should be compiled specially for 1.3.0B against it's dlls).

<blockquote data-quote="Deda" data-source="post: 944715" data-attributes="member: 89768">Problem is in enumeration of MP window id's. Because new GUI settings introduced new window names for better understanding (old names was not so clear), but not to break old naming system for 1.3.0 (in 1.4.0 old names will be removed) now exists few same window id's with different names (old one is marked in code as depreciated) which in this plugin causing exception because it takes one by one window id and as id is some kind of index it must be unique and we end on exception of already existing id.&nbsp;So to skip those duplicates we must skip old windows in MPwindow enumeration withcase (int)GUIWindow.Window.WINDOW_SETTINGS_SCREEN:case (int)GUIWindow.Window.WINDOW_SETTINGS_SLIDESHOW:case (int)GUIWindow.Window.WINDOW_SETTINGS_GUI:case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIN:case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIPSTEPS:continue;&nbsp;&nbsp;@[USER=24295]rsenden[/USER] needs to take care of this in code and all will be ok after (but it should be compiled specially for 1.3.0B against it's dlls).</blockquote>

[QUOTE="Deda, post: 944715, member: 89768"] Problem is in enumeration of MP window id's. Because new GUI settings introduced new window names for better understanding (old names was not so clear), but not to break old naming system for 1.3.0 (in 1.4.0 old names will be removed) now exists few same window id's with different names (old one is marked in code as depreciated) which in this plugin causing exception because it takes one by one window id and as id is some kind of index it must be unique and we end on exception of already existing id. So to skip those duplicates we must skip old windows in MPwindow enumeration with case (int)GUIWindow.Window.WINDOW_SETTINGS_SCREEN: case (int)GUIWindow.Window.WINDOW_SETTINGS_SLIDESHOW: case (int)GUIWindow.Window.WINDOW_SETTINGS_GUI: case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIN: case (int)GUIWindow.Window.WINDOW_SETTINGS_SKIPSTEPS: continue; [FONT=arial]@[USER=24295]rsenden[/USER] needs to take care of this in code and all will be ok after (but it should be compiled specially for 1.3.0B against it's dlls).[/FONT] [/QUOTE]