home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Plugin Development
Get every episode from a Season
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="morpheus_xx" data-source="post: 1154869" data-attributes="member: 48495"><p>Some remarks:</p><p></p><p>1) --> please introduce a variable for it, it will be accessed twice</p><p></p><p></p><p>2) why do you parse the season from Title? There is the SeriesAspect.Season attribute you can use directly.</p><p></p><p>3) Please reduce them number of methods, i.e.:</p><p>internal static MediaItem GetMediaItemById(string id, ISet<Guid> necessaryMIATypes, ISet<Guid> optionalMIATypes)</p><p>--> if you expect to query always by MediaItem Id, then the Guid version is enough. Parsing (TryParse) the Guid should then be done in step 1)</p></blockquote><p></p>
[QUOTE="morpheus_xx, post: 1154869, member: 48495"] Some remarks: 1) --> please introduce a variable for it, it will be accessed twice 2) why do you parse the season from Title? There is the SeriesAspect.Season attribute you can use directly. 3) Please reduce them number of methods, i.e.: internal static MediaItem GetMediaItemById(string id, ISet<Guid> necessaryMIATypes, ISet<Guid> optionalMIATypes) --> if you expect to query always by MediaItem Id, then the Guid version is enough. Parsing (TryParse) the Guid should then be done in step 1) [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Plugin Development
Get every episode from a Season
Contact us
RSS
Top
Bottom