Reply to thread

Message

<blockquote data-quote="popy" data-source="post: 1123472" data-attributes="member: 114134">Update: I have solved it.The issue is in the ByteArray.cs of CornerStone.Old Code:[code]&nbsp; &nbsp; &nbsp; &nbsp; public byte[] Data {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; get {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (_data.Length == 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return _data;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; set { _data = value; }&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; private byte[] _data = null;&nbsp; &nbsp; &nbsp; &nbsp; public ByteArray() {&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; public ByteArray(byte[] data) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _data = data;&nbsp; &nbsp; &nbsp; &nbsp; }[/code]Ill think it happens that when an new ByteArray is instanced with no given &quot;data&quot; and &quot;Data&quot; is accessed, the code access &quot;_data.Length&quot; (bold above) and there the exception is thrown!Fixed Code:[code]&nbsp; &nbsp; &nbsp; &nbsp; public byte[] Data {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; get {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((_data == null) || (_data.Length == 0))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return _data;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; set { _data = value; }&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; private byte[] _data = null;&nbsp; &nbsp; &nbsp; &nbsp; public ByteArray() {&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; public ByteArray(byte[] data) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _data = data;&nbsp; &nbsp; &nbsp; &nbsp; }[/code]My workaround in my current code of WatchedSyncronizer:[code]&nbsp; &nbsp; private void OnMovingPicturesDatabaseUpdated(DatabaseTable dbObject, TableUpdateInfo ui)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; WatchedStateEvent curEvent = new WatchedStateEvent();&nbsp; &nbsp; &nbsp; &nbsp; byte[] bteTmpResumeData = new byte[] { };&nbsp; &nbsp; &nbsp; &nbsp; // If it is user settings for a movie&nbsp; &nbsp; &nbsp; &nbsp; if (dbObject.GetType() != typeof(DBUserMovieSettings))&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Debug(&quot;WatchedSynchronizer: OnMovingPicturesDatabaseUpdated: unknown object type: '&quot; + dbObject.GetType().ToString() + &quot;', event dropped!&quot;);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return;&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; //Cast to DBUserMovieSettings object and get movie details&nbsp; &nbsp; &nbsp; &nbsp; DBUserMovieSettings userMovieSettings = (DBUserMovieSettings)dbObject;&nbsp; &nbsp; &nbsp; &nbsp; DBMovieInfo movie = userMovieSettings.AttachedMovies[0];&nbsp; &nbsp; &nbsp; &nbsp; //check if userMovieSettings.ResumeData is null or empty string&nbsp; &nbsp; &nbsp; &nbsp; //if that is the case reinitialize userMovieSettings.ResumeData with an empty byte array to prevent null exception when accessing userMovieSettings.ResumeData.Data&nbsp; &nbsp; &nbsp; &nbsp; //this should be fixed in ByteArray.cs of Cornerstone. There is access to _data.length and NO null check before!&nbsp; &nbsp; &nbsp; &nbsp; if ((userMovieSettings.ResumeData == null) || (userMovieSettings.ResumeData.ToString() == &quot;&quot;))&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; userMovieSettings.ResumeData = new ByteArray(bteTmpResumeData);&nbsp; &nbsp; &nbsp; &nbsp; }[/code]pOpY</blockquote>

[QUOTE="popy, post: 1123472, member: 114134"] Update: I have solved it. The issue is in the ByteArray.cs of CornerStone. Old Code: [code] public byte[] Data { get { if (_data.Length == 0) return null; else return _data; } set { _data = value; } } private byte[] _data = null; public ByteArray() { } public ByteArray(byte[] data) { _data = data; }[/code] Ill think it happens that when an new ByteArray is instanced with no given "data" and "Data" is accessed, the code access [B]"_data.Length" (bold above)[/B] and there the exception is thrown! Fixed Code: [code] public byte[] Data { get { if ((_data == null) || (_data.Length == 0)) return null; else return _data; } set { _data = value; } } private byte[] _data = null; public ByteArray() { } public ByteArray(byte[] data) { _data = data; }[/code] My workaround in my current code of WatchedSyncronizer: [code] private void OnMovingPicturesDatabaseUpdated(DatabaseTable dbObject, TableUpdateInfo ui) { WatchedStateEvent curEvent = new WatchedStateEvent(); byte[] bteTmpResumeData = new byte[] { }; // If it is user settings for a movie if (dbObject.GetType() != typeof(DBUserMovieSettings)) { Log.Debug("WatchedSynchronizer: OnMovingPicturesDatabaseUpdated: unknown object type: '" + dbObject.GetType().ToString() + "', event dropped!"); return; } //Cast to DBUserMovieSettings object and get movie details DBUserMovieSettings userMovieSettings = (DBUserMovieSettings)dbObject; DBMovieInfo movie = userMovieSettings.AttachedMovies[0]; //check if userMovieSettings.ResumeData is null or empty string //if that is the case reinitialize userMovieSettings.ResumeData with an empty byte array to prevent null exception when accessing userMovieSettings.ResumeData.Data //this should be fixed in ByteArray.cs of Cornerstone. There is access to _data.length and NO null check before! if ((userMovieSettings.ResumeData == null) || (userMovieSettings.ResumeData.ToString() == "")) { userMovieSettings.ResumeData = new ByteArray(bteTmpResumeData); }[/code] pOpY [/QUOTE]

Verification