Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 732221" data-attributes="member: 82144">No it won't limit us for the IsSameTransponder() thing - that relates to the TVCardHDPVR class and its use of the AnalogChannel class. I don't think it will limit us too much for other things either. The way I see it, the HDPVR is like an analog tuner that tunes DVB channels. There are *major* code overlaps with the analog tuner and DVB subchannel code that can be taken advantage of.From a maintenance standpoint, reusing as much of the TvDvbChannel code makes perfect sense. Almost all the development and testing effort for hardware is focussed on DVB tuners because those are the tuners that we as developers own, and because most MP users use DVB tuners too. The whole reason the HDPVR support was broken in the first place is that someone made some major changes to the DVB and general code and either wasn't able or didn't bother to check the analog, hybrid, and HDPVR code. If the HDPVR was already reusing code then I think it would have been far less likely to happen.The loss of flexibility is definitely a downside to code reuse. Combining analog tuner code with DVB subchannel code can also be awkward (as I've already proved). If the HDPVR subchannel code was more different then I don't think I'd have done what I've done, but actually it was almost identical apart from the conditional access support and the fixed service ID and PMT PID. Those haven't been hard to work around, and in my opinion the benefits from code reuse will outweigh the drawbacks over time...</blockquote>

[QUOTE="mm1352000, post: 732221, member: 82144"] No it won't limit us for the IsSameTransponder() thing - that relates to the TVCardHDPVR class and its use of the AnalogChannel class. I don't think it will limit us too much for other things either. The way I see it, the HDPVR is like an analog tuner that tunes DVB channels. There are *major* code overlaps with the analog tuner and DVB subchannel code that can be taken advantage of. From a maintenance standpoint, reusing as much of the TvDvbChannel code makes perfect sense. Almost all the development and testing effort for hardware is focussed on DVB tuners because those are the tuners that we as developers own, and because most MP users use DVB tuners too. The whole reason the HDPVR support was broken in the first place is that someone made some major changes to the DVB and general code and either wasn't able or didn't bother to check the analog, hybrid, and HDPVR code. If the HDPVR was already reusing code then I think it would have been far less likely to happen. The loss of flexibility is definitely a downside to code reuse. Combining analog tuner code with DVB subchannel code can also be awkward (as I've already proved). If the HDPVR subchannel code was more different then I don't think I'd have done what I've done, but actually it was almost identical apart from the conditional access support and the fixed service ID and PMT PID. Those haven't been hard to work around, and in my opinion the benefits from code reuse will outweigh the drawbacks over time... [/QUOTE]

Verification