Reply to thread

Message

<blockquote data-quote="ajs" data-source="post: 1164938" data-attributes="member: 68833">[USER=76888]@kiwijunglist[/USER]Try set &quot;Max Filesize (MB) - If the filesize of the potential sample file is below this value it will be skipped.&quot; to large value, like 500 or bigger ... but:[CODE=C#]long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024;bool match = (file.Length &lt; sampleMaxSize);if(match){...[/CODE]IMHO wrong logic <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite3" alt=":(" title="Frown&nbsp; &nbsp; :(" loading="lazy" data-shortname=":(" /> I would have done so:[CODE=C#]public static bool isSampleFile(FileInfo file) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // Create the sample filter regular expression&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Regex expr = new Regex(MovingPicturesCore.Settings.SampleRegExFilter, RegexOptions.IgnoreCase);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // Set sample max size in bytes and check the file size&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bool match = (file.Length &lt; sampleMaxSize);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!match) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // check the filename&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; match = expr.Match(file.Name).Success;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!match &amp;&amp; MovingPicturesCore.Settings.SampleIncludeFolderName) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // check the folder name if specified&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; match = expr.Match(file.DirectoryName).Success;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; // Return result of given conditions&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return match;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception e) {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (e is ThreadAbortException)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; throw e;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; logger.Warn(&quot;Sample file check failed: {0}&quot;, e.Message);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }[/CODE]</blockquote>

[QUOTE="ajs, post: 1164938, member: 68833"] [USER=76888]@kiwijunglist[/USER] Try set "[B]Max Filesize (MB)[/B] - If the filesize of the potential sample file is below this value it will be skipped." to large value, like 500 or bigger ... but: [CODE=C#]long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024; bool match = (file.Length < sampleMaxSize); if(match){...[/CODE] IMHO wrong logic :( I would have done so: [CODE=C#]public static bool isSampleFile(FileInfo file) { try { // Create the sample filter regular expression Regex expr = new Regex(MovingPicturesCore.Settings.SampleRegExFilter, RegexOptions.IgnoreCase); // Set sample max size in bytes and check the file size long sampleMaxSize = MovingPicturesCore.Settings.MaxSampleFilesize * 1024 * 1024; bool match = (file.Length < sampleMaxSize); if (!match) { // check the filename match = expr.Match(file.Name).Success; if (!match && MovingPicturesCore.Settings.SampleIncludeFolderName) { // check the folder name if specified match = expr.Match(file.DirectoryName).Success; } } // Return result of given conditions return match; } catch (Exception e) { if (e is ThreadAbortException) throw e; logger.Warn("Sample file check failed: {0}", e.Message); return false; } }[/CODE] [/QUOTE]

Verification