Reply to thread

Message

<blockquote data-quote="ajs" data-source="post: 1205427" data-attributes="member: 68833">Here it is a small change will not affect the skins work, and will work just as described in the wiki.<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L265-L278" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L265-L278</a>[code=csharp]&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (valueText.Length &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bool isNamedColor = false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bool isSharp = false;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (valueText[0] == '#' &amp;&amp; valueText.Length &gt; 1)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; valueText = valueText.Substring(1);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; isSharp = true;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; foreach (char ch in valueText)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (ch &gt;= '0' &amp;&amp; ch &lt;= '9' || ch &gt;= 'A' &amp;&amp; ch &lt;= 'F' || ch &gt;= 'a' &amp;&amp; ch &lt;= 'f')&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; continue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; isNamedColor = true;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; break;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (isNamedColor &amp;&amp; isSharp) // Property&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; valueText = &quot;#&quot; + valueText;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }[/code]Then the color specified in the skins as #AARRGGBB, AARRGGBB operate the same.[USER=141969]@CyberSimian[/USER] [USER=54906]@catavolt[/USER]Make JIRA Ticket? Make Corrections? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite27" alt=":whistle:" title="Whistling&nbsp; &nbsp; :whistle:" loading="lazy" data-shortname=":whistle:" /><img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite29" alt=":coffee:" title="Coffee&nbsp; &nbsp; :coffee:" loading="lazy" data-shortname=":coffee:" />In MP Wiki, Color can have a value:<ul>
<li data-xf-list-type="ul">Hex values in the format #RRGGBB</li>
<li data-xf-list-type="ul">Hex values in the format #AARRGGBB</li>
<li data-xf-list-type="ul">Named colors</li>
</ul>No decimal, only hexadecimal for non named color ... <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /></blockquote>

[QUOTE="ajs, post: 1205427, member: 68833"] Here it is a small change will not affect the skins work, and will work just as described in the wiki. [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L265-L278[/URL] [code=csharp] if (valueText.Length > 0) { bool isNamedColor = false; bool isSharp = false; if (valueText[0] == '#' && valueText.Length > 1) { valueText = valueText.Substring(1); isSharp = true; } foreach (char ch in valueText) { if (ch >= '0' && ch <= '9' || ch >= 'A' && ch <= 'F' || ch >= 'a' && ch <= 'f') { continue; } isNamedColor = true; break; } if (isNamedColor && isSharp) // Property { valueText = "#" + valueText; }[/code] Then the color specified in the skins as #AARRGGBB, AARRGGBB operate the same. [USER=141969]@CyberSimian[/USER] [USER=54906]@catavolt[/USER] Make JIRA Ticket? Make Corrections? :whistle::coffee: In MP Wiki, Color can have a value: [LIST] [*]Hex values in the format #RRGGBB [*]Hex values in the format #AARRGGBB [*]Named colors [/LIST] No decimal, only hexadecimal for non named color ... :) [/QUOTE]

Verification