Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1205437" data-attributes="member: 82144">I already explained! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite12" alt="o_O" title="Er... what?&nbsp; &nbsp; o_O" loading="lazy" data-shortname="o_O" />If I give you a yellow lemon when you ask for a green apple, I will assume that the yellow lemon is okay if you don't complain. You should have complained if the green apple was really important.Yes, I agree... but if the skin engine gives the designer black instead of AARRGGBB and the designer does not complain, the designer must think that black is okay too. Now after X years the designer and people who use the designer's skin expect black. If you change the black to AARRGGBB, the designer and users will be angry with you. It's much easier to fix the wiki and say that #AARRGGBB is not a valid colour value. That way the skin engine will stay the same and nobody will be angry.Of course something changes!Now #AARRGGBB gives black.After your change, #AARRGGBB will give AARRGGBB.You know that MP only supports HEX colours... but other people do not. CyberSimian already thought # means HEX and no # means DECIMAL. If you add support for #AARRGGBB, even more people will be confused.But other earlier procedures do! # means skin engine defined value (eg. BasicHome.xml: &lt;define&gt;#selecteditem:&lt;/define&gt; etc.):<a href="https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L556-L571" target="_blank">https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L556-L571</a>Please, let's just leave the code alone! There's no need to add support for #AARRGGBB.</blockquote>

[QUOTE="mm1352000, post: 1205437, member: 82144"] I already explained! o_O If I give you a yellow lemon when you ask for a green apple, I will assume that the yellow lemon is okay if you don't complain. You should have complained if the green apple was really important. Yes, I agree... but if the skin engine gives the designer black instead of AARRGGBB and the designer does not complain, the designer must think that black is okay too. Now after X years the designer and people who use the designer's skin expect black. If you change the black to AARRGGBB, the designer and users will be angry with you. It's much easier to fix the wiki and say that #AARRGGBB is not a valid colour value. That way the skin engine will stay the same and nobody will be angry. Of course something changes! Now #AARRGGBB gives black. After your change, #AARRGGBB will give AARRGGBB. You know that MP only supports HEX colours... but other people do not. CyberSimian already thought # means HEX and no # means DECIMAL. If you add support for #AARRGGBB, even more people will be confused. But other earlier procedures do! # means skin engine defined value (eg. BasicHome.xml: <define>#selecteditem:</define> etc.): [URL]https://github.com/MediaPortal/MediaPortal-1/blob/master/mediaportal/Core/guilib/GUIControlFactory.cs#L556-L571[/URL] Please, let's just leave the code alone! There's no need to add support for #AARRGGBB. [/QUOTE]

Verification