IMDB+ collection issue (1 Viewer)

styrsven

Portal Pro
January 6, 2013
115
51
59
Sweden Sweden
Country flag
I have recently moved back from my films to moving pictures. When rescanning my colliction, I couldn't help but notice the movies belonging to the IMDB top 250 collection don't belong to other collections although they should. E.g. tt0112471 "Before sunrise", in swedish "Bara en natt", belongs to |» IMDb Top 250| according to the scraper, but according to C:\ProgramData\Team MediaPortal\MediaPortal\IMDb+\Rename dBase IMDb+ Scraper.xml it should also belong to
<rename id="tt0112471" title="Before Sunrise" sortby="Before Sunrise 1" collection="Before Sunrise" />

Anyone got a hint of where the error might be?
 

styrsven

Portal Pro
January 6, 2013
115
51
59
Sweden Sweden
Country flag
After some trial and error and memories slowly coming back, I swapped the order of the sortby and collection tags in the rename database for this collection, and suddenly the renaming started working.
 

styrsven

Portal Pro
January 6, 2013
115
51
59
Sweden Sweden
Country flag
More experiences of the renamer:
It seems it has some issues with collection names from different sources.
When I did the fix in the previous post, "Before sunrise" was added to "Befor sunrise" collection, but also disappeared from the IMDB top 250 collection.
Also, the Rocky collection has the collection extracted from the name, but Rocky I is not included in the collection because it also is specifically included in the Oscars collection. After adding Rocky in the collection field it is included in both.
The same goes for "Silence of the lambs".
 

RoChess

Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,348
    1,828
    Country flag
    @styrsven, I noticed that bug myself as well on another movie, and was a logic mistake in the way Top250 works, including another bug on subtitle movies, and both are fixed now with new version.

    Did not get around to fixing it until today, so grab latest version and I would let the IMDb+ plugin do a full refresh on all the replacement dbase entries so that it can fix all the Top 250 and other collections issues, such as "Mission: Impossible IV - Ghost Protocol".

    PS: You just made me realize I overlooked the "Rocky I" mistake, which should be in Top250, but indeed fails on the Rocky collections, because it needs to be manually added to that when I overwrite the collection tag. Will fix that.
     

    styrsven

    Portal Pro
    January 6, 2013
    115
    51
    59
    Sweden Sweden
    Country flag
    Thanks RoChess,
    I also think there is an issue that the attributes in the translation file has to be in the exact same order as they are listed in the regular expression in the grabber script, or else some attribute(s) is/are missed. That means you have to peek in the grabber script to be sure to get the translation right. Maybe it can be addressed by splitting up in several regexes or using xpath?
     

    RoChess

    Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,348
    1,828
    Country flag
    Well that is why I specify the exact syntax at the top. RegExp had a massive improvement in speed over xpath, because it allows me to immediately jump to the "one" entry, whereas xpath first resolves every node. There is logic behind the madness :)
     

    styrsven

    Portal Pro
    January 6, 2013
    115
    51
    59
    Sweden Sweden
    Country flag
    Ok..
    There are a number of samples in the translation file that doesn't follow the exact syntax, e.g.

    <rename id="tt0478970" sortby="Ant-Man I" collection="The Avengers|» Superheroes" />

    where 'sortby' preceeds 'collection' so the scraper finds 'sortby' but misses 'collection'.

    In some places (like the sample above) I suspect that 'sortby' should really be 'title', but in other places it is just an obvious error, like

    <rename id="tt0112471" title="Before Sunrise" sortby="Before Sunrise 1" collection="Before Sunrise" />
    <rename id="tt0381681" title="Before Sunset" sortby="Before Sunrise 2" collection="Before Sunrise" />
    <rename id="tt2209418" title="Before Midnight" sortby="Before Sunrise 3" collection="Before Sunrise" />
     

    RoChess

    Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,348
    1,828
    Country flag
    The syntax with RegEx was designed to allow for options to be skipped, as long as the order is correct.

    But you are totally right, somewhere along the line I totally screwed things up, because the RegExp expects title/collection/foreign/sortby, and I have been editing the dbase as title/foreign/sortby/collection

    Can't believe nobody caught that before, especially me :)
     

    RoChess

    Extension Developer
  • Premium Supporter
  • March 10, 2006
    4,348
    1,828
    Country flag
    Okay, all fixed with new update on scraper-script, and master dBase, will make a post in main thread with more details.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    B Overhaul IMDb+ rating system IMDb+ 5
    RoChess IMDb tt-ID expansion Moving Pictures 11
    D Ripped movies not importing unless IMDB code is included in folder name General 4
    fredco IMDb+ wants Dutch titles! IMDb+ 0
    W [solved] MP 1.20 Video IMDB no showing plot General Support 129
    Terra IMDB Scraper issue? HTML Tags in results Moving Pictures 2
    M [solved] IMDB script broken again General Support 67
    H [solved] Video database genres, sort titles and collection thumbnails Newcomers Forum 12
    R Fill Collection Field of Movies? Moving Pictures 0
    M Collection was modified; enumeration operation may not execute General Support 0
    horned_reaper Issue with / character in artist name Fanart Handler 5
    1gkar A Couple of {On-going} Issues Within Various MP Versions General Support 25
    R MP2 GUI Issues General 7
    morpheus_xx [WiP] WIP 2.3 Fanart issues? MediaPortal 2 13
    morpheus_xx [Help Me!] Build issues on TeamCity MediaPortal 2 1
    W Not finding/matching new series - thetvdb issue? My TVSeries 3
    J [fixed] Import issue with alternate movie title matching the name of another movie Submit: Bug Reports 7
    1gkar Latest Intel HD4600 Drivers Issue General Support 1
    J Odd issues with Freesat EPG - MP2 General 18
    DHosein Mediaportal & Antimalware Service High CPU issue General Support 2
    J MediaPortal TV Server and Kodi media source issues General 9
    S Movie navigation issues in MP2 General 8
    cbr954rr Issue BOOTSUWRNQ with online videos? Plugin Development 1
    2BitSculptor MP1.23 release mediainfo issue? MediaPortal 1 Talk 4
    A TV Channel Combination - case issue Television (MyTV frontend and TV-Server) 0
    Top Bottom