[fixed] [JIRA MP1-2469] - DetectDrive method obsolete ? (2 Viewers)

[Deda]

Problem is that this has to be rewritten so it can detect real device add/remove (is it USB, eSATA, firewire..., thunderbolt ), like it is now it's impossible and I'm not so god on system lvl code and Win low lvl API.

RemovableDriveHelper.cs looks more as C++ than C# code

Just for detection of USB HDDs you actually need also knowledge of SQL language as MS failed to help us there. I think net 4 is better in this but as we're now on net 3 it's complicated as hell.

 

[catavolt]

@catavolt : have you icon for Removable drive ?

As I stated some posts above the pngs are part of Default skins already

 

[Deda]

Maybe on your system but I can't see it in current master

so obviously in this A-Z sort defaultRemovable.png/defaultRemovableBig.png is not here , when I add images with those names, icons are visible.

 

[catavolt]

How could they get deleted from there?

 

[Deda]

Maybe you board on wrong train

 

[catavolt]

OK - here they are to test (the original ones of all time)
I´ll make up some nicer ones and commit to master later

 

[Deda]

Maybe this can help you , probably there is more missing after merge of this


Actually I think this has to be reviewed maybe it's more than only skin (just got a bad feeling), it's not merging master into branch but something before which deletes those images in master

 

[catavolt]

Here are the new ones - think they are nicer

 

[elliottmc]

Maybe this can help you , probably there is more missing after merge of this
View attachment 127129

Actually I think this has to be reviewed maybe it's more than only skin (just got a bad feeling)

We need to check which files were deleted by this, for sure. They can easily be replaced. From a code point of view, I have not noticed anything not working, so hopefully it's not worse.

 

[Deda]

It's not merge master fault, but master was like that before merging so deleting happened before (I updated my post ) so it's skin only missing files.