Reply to thread

Message

<blockquote data-quote="sccrgoalie1" data-source="post: 1027745" data-attributes="member: 143879">I've submitted a pull request with updated code to support live commercial skipping and toggling of automatic commercial skipping.&nbsp; This request consists of a couple areas of change.1. Added two new actions ACTION_TOGGLE_AUTO_COMMERCIAL_SKIP and ACTION_STEP_BACK_PREVIOUS_JUMP that can be assigned buttons.&nbsp; The first allows you to toggle auto commercial skip while watching a program, and the second allows you to jump back to the previous jump point in the case of an erroneous jump.2. Update g_player to support the new actions and support live reading of .edl files.&nbsp; These will be the new default commercial file for Media Portal as they don't rely on a Framerate to get the commercial position.&nbsp; In your comskip.ini you must set output_edl=1 to get that file.3. Add in filewatcher to watch the commercial file and reload when there is a change.&nbsp; This allows for skipping while a file is currently being recorded.&nbsp; Say for example I start watching a show 15 minutes after the start, I now should get auto skipping throughout.4. Update commercial skipping logic such that if you for some reason end up in a commercial segment with auto skipping enabled you will be skipped right to the end of the segment.&nbsp; Previously you had to be watching up to the skip point for the skip to work.&nbsp; Now if I skip into the commercial segment the algorithm will quickly skip me to the end.5.&nbsp; Added an event for Skin dev's to subscribe to to be notified when there are changes to the chapter segments (I'm not sure this is necessary as they may load on demand (when the progress bar shows) anyway)Here's my fork:<a href="https://github.com/sccrgoalie1/MediaPortal-3" target="_blank">https://github.com/sccrgoalie1/MediaPortal-3</a></blockquote>

[QUOTE="sccrgoalie1, post: 1027745, member: 143879"] I've submitted a pull request with updated code to support live commercial skipping and toggling of automatic commercial skipping. This request consists of a couple areas of change. 1. Added two new actions ACTION_TOGGLE_AUTO_COMMERCIAL_SKIP and ACTION_STEP_BACK_PREVIOUS_JUMP that can be assigned buttons. The first allows you to toggle auto commercial skip while watching a program, and the second allows you to jump back to the previous jump point in the case of an erroneous jump. 2. Update g_player to support the new actions and support live reading of .edl files. These will be the new default commercial file for Media Portal as they don't rely on a Framerate to get the commercial position. In your comskip.ini you must set output_edl=1 to get that file. 3. Add in filewatcher to watch the commercial file and reload when there is a change. This allows for skipping while a file is currently being recorded. Say for example I start watching a show 15 minutes after the start, I now should get auto skipping throughout. 4. Update commercial skipping logic such that if you for some reason end up in a commercial segment with auto skipping enabled you will be skipped right to the end of the segment. Previously you had to be watching up to the skip point for the skip to work. Now if I skip into the commercial segment the algorithm will quickly skip me to the end. 5. Added an event for Skin dev's to subscribe to to be notified when there are changes to the chapter segments (I'm not sure this is necessary as they may load on demand (when the progress bar shows) anyway) Here's my fork: [url]https://github.com/sccrgoalie1/MediaPortal-3[/url] [/QUOTE]

Verification