[Pending] Live commercial skip detection (1 Viewer)

sccrgoalie1

Portal Pro
September 12, 2013
109
165
34
United States of America United States of America
I've submitted a pull request with updated code to support live commercial skipping and toggling of automatic commercial skipping. This request consists of a couple areas of change.

1. Added two new actions ACTION_TOGGLE_AUTO_COMMERCIAL_SKIP and ACTION_STEP_BACK_PREVIOUS_JUMP that can be assigned buttons. The first allows you to toggle auto commercial skip while watching a program, and the second allows you to jump back to the previous jump point in the case of an erroneous jump.

2. Update g_player to support the new actions and support live reading of .edl files. These will be the new default commercial file for Media Portal as they don't rely on a Framerate to get the commercial position. In your comskip.ini you must set output_edl=1 to get that file.

3. Add in filewatcher to watch the commercial file and reload when there is a change. This allows for skipping while a file is currently being recorded. Say for example I start watching a show 15 minutes after the start, I now should get auto skipping throughout.

4. Update commercial skipping logic such that if you for some reason end up in a commercial segment with auto skipping enabled you will be skipped right to the end of the segment. Previously you had to be watching up to the skip point for the skip to work. Now if I skip into the commercial segment the algorithm will quickly skip me to the end.

5. Added an event for Skin dev's to subscribe to to be notified when there are changes to the chapter segments (I'm not sure this is necessary as they may load on demand (when the progress bar shows) anyway)

Here's my fork:
https://github.com/sccrgoalie1/MediaPortal-3
 
Last edited:

elliottmc

Retired Team Member
  • Premium Supporter
  • August 7, 2005
    14,927
    6,061
    Cardiff, UK
    United Kingdom United Kingdom
    Country flag
    Could you please explain from a user perspective what will happen when you try to skip commercials with this patch, and what currently happens, so that the difference is clear?
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    34
    United States of America United States of America
    Sure, there are two main changes with the release of this patch.

    1. If you start watching a show that is currently recording, Media Portal now has the ability to keep reloading the commercial jump points while you are watching. This means, for example, you can start an hour show 15 minutes in and never see any commercials.

    2. Previously you had to be watching a show right to the jump point. If you accidentally skipped over a jumped point the commercial segment would not be skipped. Now Media Portal considers the entire commercial span (eg. from 1 min - 2 minute). If I end up at any point between 1 and 2 minutes the commercial skip will automatically happen (if enabled). Along with this comes two new actions that can be assigned to buttons. First is an action to toggle automatic commercial skip while watching a show. This allows you to turn off the auto commercial skip just for a single show if it's not working right. The second is an action to jump back to the previous skip point. This allows you to skip back to the point at which you were last skipped automatically (this is great if a commercial segment is slightly misidentified). These two actions should be used together because before you skip back to the previous jump point you need to turn off auto commercial skipping otherwise it will just do the skip again.

    Hopefully, that helps. If not, please let me know what's unclear.
     

    johanj

    MP Donator
  • Premium Supporter
  • January 31, 2009
    781
    398
    42
    Sweden Sweden
    I thought that a the main problem of adding comskip to live tv was that comskip had problems with the live ts file. Has those problems been adressed or do I remember it wrong?
     

    sccrgoalie1

    Portal Pro
    September 12, 2013
    109
    165
    34
    United States of America United States of America
    I've only been using Media Portal and thus .ts files for about a month, but comskip hasn't had a single issue with the live ts files.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    K MP1.24 HDHomeRun Quatro DVT2 - Pixelation on live TV General Support 1
    S IPTV from online m3u8 for Aussie Live TV General Support 10
    K Flickering live TV playback Newcomers Forum 3
    H [solved] MP2 Wiedergabe von Aufnahmen und Live TV geht nicht Allgemeines Support- und Diskussionsforum 6
    torone Dritter versuch mit Mediaportal 2 Allgemeines Support- und Diskussionsforum 1
    W [solved] MP suddenly Crashes when starting live TV on most channels and on recordings from the same channels General Support 20
    W [solved] MP suddenly Crashes when starting live TV on some channels and on some recordings Television (MyTV frontend and TV-Server) 1
    vvulture UNKNOWN ERROR when starting live TV General Support 6
    H random black screen live tv and videos (amended) General Support 0
    404 [solved] Live TV...video and audio freeze General Support 20
    404 How to turn off narration on live tv General 2
    Volker MP2 Rewind / zurückspulen bei Live TV funktioniert nicht Allgemeines Support- und Diskussionsforum 3
    G Occasional Black screen on Live TV and Recorded TV Watch / Listen Media 5
    G Live Tv friert ein Allgemeines Support- und Diskussionsforum 47
    U [solved] Beginner needs help recording live TV General 19
    limpwhizkid 1.22.0 Stutter and or artifact problem when recording and watching the same live tv channel 1.22 2
    rbo Fehlermeldung im Live-TV TV / Streaming 6
    R Pixellation on live TV every few seconds General Support 11
    M After a while Live TV or Recorded TV doesn't play first time General Support 9
    S [solved] Live TV subtitle issue if not using 100% font General 31
    S [solved] Live TV playing stopped General 13
    S Mediaportal 1.22 Pre-Release remote live-tv freezes MediaPortal 1.22 Pre Release 0
    H Live TV info OSD not displaying number of audio channels General Support 3
    E [solved] No Live TV in MP2.2 Client - Can TEST Successfully in "MediaPortal 2 TV Configuration" utility General 8
    D Skip to end/live during dvbip recording causes it to stop playing instead. General Support 15
    Similar threads

























    Top Bottom