[Pending] - Live commercial skip detection

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by sccrgoalie1, September 16, 2013.

  1. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    I've submitted a pull request with updated code to support live commercial skipping and toggling of automatic commercial skipping. This request consists of a couple areas of change.

    1. Added two new actions ACTION_TOGGLE_AUTO_COMMERCIAL_SKIP and ACTION_STEP_BACK_PREVIOUS_JUMP that can be assigned buttons. The first allows you to toggle auto commercial skip while watching a program, and the second allows you to jump back to the previous jump point in the case of an erroneous jump.



    2. Update g_player to support the new actions and support live reading of .edl files. These will be the new default commercial file for Media Portal as they don't rely on a Framerate to get the commercial position. In your comskip.ini you must set output_edl=1 to get that file.

    3. Add in filewatcher to watch the commercial file and reload when there is a change. This allows for skipping while a file is currently being recorded. Say for example I start watching a show 15 minutes after the start, I now should get auto skipping throughout.

    4. Update commercial skipping logic such that if you for some reason end up in a commercial segment with auto skipping enabled you will be skipped right to the end of the segment. Previously you had to be watching up to the skip point for the skip to work. Now if I skip into the commercial segment the algorithm will quickly skip me to the end.

    5. Added an event for Skin dev's to subscribe to to be notified when there are changes to the chapter segments (I'm not sure this is necessary as they may load on demand (when the progress bar shows) anyway)

    Here's my fork:
    https://github.com/sccrgoalie1/MediaPortal-3
     
    Last edited: October 24, 2013
    • Thank You! Thank You! x 5
    • Like Like x 4
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. manyakim
    • Premium Supporter

    manyakim MP Donator

    Joined:
    November 20, 2005
    Messages:
    36
    Likes Received:
    9
    Gender:
    Male
    Location:
    Zeeland
    Ratings:
    +10 / 0
    Home Country:
    Netherlands Netherlands
    Show System Specs
    That would be awesome.
    Thank you for making this possible.
     
  4. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
  5. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
  6. Sebastiii
    • Team MediaPortal

    Sebastiii Development Group

    Joined:
    November 12, 2007
    Messages:
    16,275
    Likes Received:
    6,223
    Gender:
    Male
    Location:
    France
    Ratings:
    +10,235 / 9
    Home Country:
    France France
    Show System Specs
    • Like Like x 2
    • Thank You! Thank You! x 1
  7. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    Absolutely. Thanks!
     
    • Like Like x 2
    • Thank You! Thank You! x 1
  8. elliottmc
    • Premium Supporter

    elliottmc Retired Team Member

    Joined:
    August 7, 2005
    Messages:
    14,927
    Likes Received:
    4,011
    Gender:
    Male
    Location:
    Cardiff, UK
    Ratings:
    +5,503 / 13
    Home Country:
    United Kingdom United Kingdom
    Show System Specs
    Could you please explain from a user perspective what will happen when you try to skip commercials with this patch, and what currently happens, so that the difference is clear?
     
  9. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    Sure, there are two main changes with the release of this patch.

    1. If you start watching a show that is currently recording, Media Portal now has the ability to keep reloading the commercial jump points while you are watching. This means, for example, you can start an hour show 15 minutes in and never see any commercials.

    2. Previously you had to be watching a show right to the jump point. If you accidentally skipped over a jumped point the commercial segment would not be skipped. Now Media Portal considers the entire commercial span (eg. from 1 min - 2 minute). If I end up at any point between 1 and 2 minutes the commercial skip will automatically happen (if enabled). Along with this comes two new actions that can be assigned to buttons. First is an action to toggle automatic commercial skip while watching a show. This allows you to turn off the auto commercial skip just for a single show if it's not working right. The second is an action to jump back to the previous skip point. This allows you to skip back to the point at which you were last skipped automatically (this is great if a commercial segment is slightly misidentified). These two actions should be used together because before you skip back to the previous jump point you need to turn off auto commercial skipping otherwise it will just do the skip again.

    Hopefully, that helps. If not, please let me know what's unclear.
     
    • Like Like x 1
    • Thank You! Thank You! x 1
  10. johanj
    • Premium Supporter

    johanj Well-Known Member

    Joined:
    January 31, 2009
    Messages:
    781
    Likes Received:
    270
    Gender:
    Male
    Ratings:
    +398 / 1
    Home Country:
    Sweden Sweden
    I thought that a the main problem of adding comskip to live tv was that comskip had problems with the live ts file. Has those problems been adressed or do I remember it wrong?
     
  11. sccrgoalie1

    sccrgoalie1 Portal Pro

    Joined:
    September 12, 2013
    Messages:
    109
    Likes Received:
    45
    Gender:
    Male
    Ratings:
    +106 / 0
    Home Country:
    United States of America United States of America
    I've only been using Media Portal and thus .ts files for about a month, but comskip hasn't had a single issue with the live ts files.
     
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!