Reply to thread

Message

I have implemented the string replacements also with support for "before" and "after". Not sure where it applied "after" in TvSeries, I do the replacement then on series name and episode name.

Jira entry created: https://issues.team-mediaportal.com/browse/MP2-515.
And changes commited to new branch: https://github.com/MediaPortal/MediaPortal-2/commit/a21afd937eee

I will create a test executable for trying the matching logic without MP2 in the next few days.

Just a not: when I enable some of the replacements from ajs above, the unit test for series matching will fail.

This means: "with great power comes great responsibility" changes are high to break the inbuilt defaults

[USERGROUP=39]@Developers[/USERGROUP] and [USERGROUP=40]@Testers[/USERGROUP]

Once this feature is well tested, we must document it in our new wiki. There our [USERGROUP=54]@DocumentationGroup[/USERGROUP] could help!

<blockquote data-quote="morpheus_xx" data-source="post: 1172512" data-attributes="member: 48495">I have implemented the string replacements also with support for &quot;before&quot; and &quot;after&quot;. Not sure where it applied &quot;after&quot; in TvSeries, I do the replacement then on series name and episode name.Jira entry created: <a href="https://issues.team-mediaportal.com/browse/MP2-515" target="_blank">https://issues.team-mediaportal.com/browse/MP2-515</a>.And changes commited to new branch: <a href="https://github.com/MediaPortal/MediaPortal-2/commit/a21afd937eee" target="_blank">https://github.com/MediaPortal/MediaPortal-2/commit/a21afd937eee</a>I will create a test executable for trying the matching logic without MP2 in the next few days.Just a not: when I enable some of the replacements from ajs above, the unit test for series matching will fail. This means: &quot;with great power comes great responsibility&quot; <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" /> changes are high to break the inbuilt defaults <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue&nbsp; &nbsp; :p" loading="lazy" data-shortname=":p" />[USERGROUP=39]@Developers[/USERGROUP]&nbsp;&nbsp; and&nbsp; [USERGROUP=40]@Testers[/USERGROUP] Once this feature is well tested, we must document it in our new wiki. There our [USERGROUP=54]@DocumentationGroup[/USERGROUP] could help!</blockquote>

[QUOTE="morpheus_xx, post: 1172512, member: 48495"] I have implemented the string replacements also with support for "before" and "after". Not sure where it applied "after" in TvSeries, I do the replacement then on series name and episode name. Jira entry created: [URL]https://issues.team-mediaportal.com/browse/MP2-515[/URL]. And changes commited to new branch: [URL]https://github.com/MediaPortal/MediaPortal-2/commit/a21afd937eee[/URL] I will create a test executable for trying the matching logic without MP2 in the next few days. Just a not: when I enable some of the replacements from ajs above, the unit test for series matching will fail. This means: "with great power comes great responsibility" ;) changes are high to break the inbuilt defaults :P [USERGROUP=39]@Developers[/USERGROUP] and [USERGROUP=40]@Testers[/USERGROUP] Once this feature is well tested, we must document it in our new wiki. There our [USERGROUP=54]@DocumentationGroup[/USERGROUP] could help! [/QUOTE]