Reply to thread

Message

<blockquote data-quote="osre" data-source="post: 1116610" data-attributes="member: 150866">I made my change at a central point, but I think I did not fully take into account, that there is not a global and a user file for all setting classes.My change looks like this:\MediaPortal\Source\Core\MediaPortal.Common\Services\Settings\SettingsManager.cs:101[CODE=C#]&nbsp; &nbsp; protected object LoadSettingsObject(Type settingsType)&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; SettingsFileHandler globalHandler = new SettingsFileHandler(GetGlobalFilePath(settingsType));&nbsp; &nbsp; &nbsp; SettingsFileHandler userHandler = new SettingsFileHandler(GetUserFilePath(settingsType));&nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; globalHandler.Load();&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; catch (Exception e)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; ServiceRegistration.Get&lt;ILogger&gt;().Error(&quot;SettingsManager: Error loading global settings file for setting type '{0}'... Will clear this settings file.&quot;, e, settingsType.Name);&nbsp; &nbsp; &nbsp; &nbsp; globalHandler.Clear();&nbsp; &nbsp; &nbsp; &nbsp; RemoveSettingsData(settingsType, false, true);&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; userHandler.Load();&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; catch (Exception e)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; ServiceRegistration.Get&lt;ILogger&gt;().Error(&quot;SettingsManager: Error loading user settings file for setting type '{0}'... Will clear this settings file.&quot;, e, settingsType.Name);&nbsp; &nbsp; &nbsp; &nbsp; userHandler.Clear();&nbsp; &nbsp; &nbsp; &nbsp; RemoveSettingsData(settingsType, true, false);&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; object result = Activator.CreateInstance(settingsType);&nbsp; &nbsp; &nbsp; &nbsp; foreach (PropertyInfo property in result.GetType().GetProperties())&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SettingAttribute att = GetSettingAttribute(property);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (att == null) continue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SettingsFileHandler s = (att.SettingScope == SettingScope.Global ? globalHandler : userHandler);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; object value = s.GetValue(property.Name, property.PropertyType);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (value == null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (att.HasDefault)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; value = att.DefaultValue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; continue;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; property.SetValue(result, value, null);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception e)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ServiceRegistration.Get&lt;ILogger&gt;().Error(&quot;SettingsManager: Error setting property '{0}' in settings of type '{1}'&quot; +&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; (att.HasDefault ? &quot;, using default value&quot; : string.Empty), e, property.Name, settingsType.Name);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (att.HasDefault)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; property.SetValue(result, att.DefaultValue, null);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; /* my modification, but I guess '||' should be replaced by an '&amp;&amp;'&nbsp; &nbsp; &nbsp; &nbsp; if (!File.Exists(globalHandler.FilePath) || !File.Exists(userHandler.FilePath))&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; SaveSettingsObject(result);&nbsp; &nbsp; &nbsp; &nbsp; }*/&nbsp; &nbsp; &nbsp; &nbsp; return result;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; catch (Exception e)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; ServiceRegistration.Get&lt;ILogger&gt;().Error(&quot;SettingsManager: Error loading settings of type '{0}'&quot;, e, settingsType.Name);&nbsp; &nbsp; &nbsp; &nbsp; return null;&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }[/CODE]About the no sound issue: may be I hit some keyboard short cut.</blockquote>

[QUOTE="osre, post: 1116610, member: 150866"] I made my change at a central point, but I think I did not fully take into account, that there is not a global and a user file for all setting classes. My change looks like this: \MediaPortal\Source\Core\MediaPortal.Common\Services\Settings\SettingsManager.cs:101 [CODE=C#] protected object LoadSettingsObject(Type settingsType) { SettingsFileHandler globalHandler = new SettingsFileHandler(GetGlobalFilePath(settingsType)); SettingsFileHandler userHandler = new SettingsFileHandler(GetUserFilePath(settingsType)); try { globalHandler.Load(); } catch (Exception e) { ServiceRegistration.Get<ILogger>().Error("SettingsManager: Error loading global settings file for setting type '{0}'... Will clear this settings file.", e, settingsType.Name); globalHandler.Clear(); RemoveSettingsData(settingsType, false, true); } try { userHandler.Load(); } catch (Exception e) { ServiceRegistration.Get<ILogger>().Error("SettingsManager: Error loading user settings file for setting type '{0}'... Will clear this settings file.", e, settingsType.Name); userHandler.Clear(); RemoveSettingsData(settingsType, true, false); } try { object result = Activator.CreateInstance(settingsType); foreach (PropertyInfo property in result.GetType().GetProperties()) { SettingAttribute att = GetSettingAttribute(property); if (att == null) continue; SettingsFileHandler s = (att.SettingScope == SettingScope.Global ? globalHandler : userHandler); try { object value = s.GetValue(property.Name, property.PropertyType); if (value == null) if (att.HasDefault) value = att.DefaultValue; else continue; property.SetValue(result, value, null); } catch (Exception e) { ServiceRegistration.Get<ILogger>().Error("SettingsManager: Error setting property '{0}' in settings of type '{1}'" + (att.HasDefault ? ", using default value" : string.Empty), e, property.Name, settingsType.Name); if (att.HasDefault) property.SetValue(result, att.DefaultValue, null); } } /* my modification, but I guess '||' should be replaced by an '&&' if (!File.Exists(globalHandler.FilePath) || !File.Exists(userHandler.FilePath)) { SaveSettingsObject(result); }*/ return result; } catch (Exception e) { ServiceRegistration.Get<ILogger>().Error("SettingsManager: Error loading settings of type '{0}'", e, settingsType.Name); return null; } }[/CODE] About the no sound issue: may be I hit some keyboard short cut. [/QUOTE]

Verification