MERGING MediaPortal Url Source Splitter & IPTV Filter (3 Viewers)

[Sebastiii]

After 2h30 of scan, TVservice goes to 140MB for 313 scanned channel.
So i would say memory goes up but not like we have with 1.5.0Pre release. i'm pretty sure that with 313 channels i will hit 2GB.

It's on 1.3.0 Final + MP1-4155 Filter and when looking @ memory usage, it goes down to 94MB.

@mm1352000 if you can help us with @georgius to try to find where does it comes.

I can see a lot of :

[2013-09-05 15:33:45,956] [Log ] [16 ] [DEBUG] - Debug: SSDPClientController: Problem parsing incoming multicast UDP packet. Error message: 'Invalid HTTP header line '''
[2013-09-05 15:35:40,073] [Log ] [15 ] [DEBUG] - Debug: SSDPClientController: Problem parsing incoming multicast UDP packet. Error message: 'Invalid HTTP header line '''
[2013-09-05 15:36:14,061] [Log ] [16 ] [DEBUG] - Debug: SSDPClientController: Problem parsing incoming multicast UDP packet. Error message: 'Invalid HTTP header line '''
[2013-09-05 15:38:22,385] [Log ] [15 ] [DEBUG] - Debug: SSDPClientController: Problem parsing incoming multicast UDP packet. Error message: 'Invalid HTTP header line '''
[2013-09-05 15:41:12,084] [Log ] [15 ] [DEBUG] - Debug: SSDPClientController: Problem parsing incoming multicast UDP packet. Error message: 'Invalid HTTP header line '''

Related to UPNP.dll, this is why, i thinking it's related but maybe not and for sure 1.3.0 didn't have this dll.

Attached is the log for 1.5.0 and 1.3.0

 

[mm1352000]

Sebastiii I'm sorry but I don't understand anything that you're saying except that you think there is a memory leak.

Please answer this question: can you reproduce the problem with MP 1.4 and the standard IPTV filter (ie. not the new one that was added in MP 1.5, and not the merged one that georgius is working on now)?

The UPnP dll has nothing to do with IPTV so I don't think it is causing the memory leak.

This is part of the problem:

[2013-09-05 13:08:18,076] [Log ] [15 ] [INFO ] - tvcard:FreeSubChannel: subchannels count 1 subch#-1
[2013-09-05 13:08:18,077] [Log ] [15 ] [INFO ] - tvcard:FreeSubChannel :-1 - sub channel not found
[2013-09-05 13:08:18,078] [Log ] [15 ] [INFO ] - tvcard:FreeSubChannel : subchannels STILL present 1, continueing graph

Subchannels not being freed correctly can lead to ever increasing memory use.

The biggest problem could be related to this:

dvb:Add source returns:0x80004005

If the service is creating a new filter instance for each scanned frequency and not freeing the old instance correctly... well then the leak will increase for each frequency scanned, and the size of the leak will be related to the memory used by each instance. Since the new IPTV filter probably uses more memory than the old one, the memory usage will increase faster.

I'm reluctant to put much effort into this problem because the TV library code for IPTV is not nice, and I already spent a lot of effort tidying/fixing it for TVE 3.5...

 

[Sebastiii]

Hi m8,

I can't reproduce the problem because original IPTV filter can't handle Freebox TV Stream (ADSL Provider) so i have no way to compare with WIP filter and original one

Thanks for input, i have retry scanning on my dev PC (with 1.3.0 + WIP Filter) -> memory leak (so like you said, that not related to UPNP.dll).

So to answer you, i can't really answer you lol.

But it seems you find why it failed, i remember (from IRC) georgius talk me about Subchannels not being freed correctly.

Can i avoid that part of code for testing ? (Yep i agree about TVE3.5) so maybe a local fix for now is needed and for sure surely needed for TVE3.5

 

[FreakyJ]

Maybe you can test if this also happens with TVE 3.5

 

[Sebastiii]

Maybe you can test if this also happens with TVE 3.5

Maybe but still so many WIP branch and not finished merged one so for now, i would say nope.

 

[Sebastiii]

Little update but give big air to TVService
Georgius seems to have find the culprit, he will able to explain it more than me.

I'm running scan and TVService stay @ 25MB

I always get this "PMT Not Found" in error log but it will not impact the fonctionnality

 

[Sebastiii]

Hi

Some update, i have a big delay between streaming channel, it was related to that the following part (but not only), i have set on my switch NETGEAR for LAN Port (for my server) Frame size to 9014 instead of 1518 (i have do that because i have make some teaming LAN) but that lead to open multiple instance of IPTV Filter.

So now it's better but we can have again multiple instance.

I have try a little rework (on my fork), i think it should be ported to TVE35 without big change (but i didn't try).

I have attached the patch for who want to look. (On my TVServer PC it better than before

 

[azzuro]

i watch TV on Freebox V6 with the files in 1st post : no issue for play streams ( single seat setup)

 

[Sebastiii]

Hi,
I'm not sure that the filter (IPTV) in first post was the latest, it's works but branch has fix about leak (if i'm not wrong).
I will update above patch before it was too agressive lol (it can failed when switching channel).

 

[Sebastiii]

This is the patch (based on current) that speedup a little loading of IPTV Stream on my server
I think big rework should be made on TVE35 to avoid to destroy graph/remove IPTV filter for each time we change the channel and just push the new IPTV URL.