[no Bug] MP Configuration Crash on exit (with FTR) (1 Viewer)

[mhoogenbosch]

It would be good to know why 4TR has some issues. Is it expecting some TV related DLLs to be present? Those files won't be present if there is no tvclient installed (that is quite obvious). Not sure why it has been working with 1.2.3, maybe because the installer was pushing some tv related content when user selected no tv support or maybe it was leftover from some other install. Hard to say.

Could it be the mantis which had something to do with cleaning legacy code?!

edit:

guess not, - 0003767: [TvServer] Remove old master/slave code (riksmith) - ready for testing. is the one i mean.

 

[Paranoid Delusion]

That mantis has nothing to do with alpha, as not introduced yet.

Will do a clean install of 1.2.3 now with FTR1.6.02 + Argus only and see what TV related files are installed and its of course working.
After will do a clean install of alpha and FTR1.7.0.0 for comparison.

 

[Paranoid Delusion]

Seems to be looking for tvcontrol.dll which is not there and I cannot find that in 1.2.3 install neither, so looks like there are files that FTR thinks are there, most probably relating to a tvserver install, which of course you have not chosen to have, same as my test.

Only thing you can do, is ask the FTR devs to cut out dependency on MP tv dll's or supply them as part of their install.,

This does seem to be a total scewup as it is, shows .net exceptions relating to different parts of MP, ie music, until you remove the FTR dlls

 

[tourettes]

supply them as part of their install.

Not a good idea for 3rd party applications to provide MP core components. If 3rd party plugins require TV related code / components from MP then they should state it as dependency and tell user to install the missing components (by using MP installer).

 

[mm1352000]

Almost certainly something in the TV section in MP configuration is requiring the DLL. I'm not sure if/how 4TR would replace this section with configuration for their own TV plugin since I think the TV configuration code is included in the MP configuration code and the section is just disabled/enabled. It is possible that a change related to the guide genre colouring is the reason for the new error message. But even if that is the case, my opinion is still that the 4TR devs will need to deal with this problem.

 

[Paranoid Delusion]

supply them as part of their install.

Not a good idea for 3rd party applications to provide MP core components. If 3rd party plugins require TV related code / components from MP then they should state it as dependency and tell user to install the missing components (by using MP installer).

You are absolutely right, should of said " dependency requires TVServer to be installed and if not wanted disabled

 

[mhoogenbosch]

Dot-I replied (DEV FTR):

This is surprising since when I look at the dependencies of the client-plugin, it really only references TvLibrary.Interfaces.dll

Confused now...

Or this is indeed an MP problem purely in their Configuration.exe?

 

[mm1352000]

I can see that MP Configuration now depends on TvControl.dll when the TV plugin is enabled.

Assembly assem = Assembly.LoadFrom(Config.GetFolder(Config.Dir.Base) + "\\TvControl.dll");

(line 346, TVClient.cs, MediaPortal.Configuration)

This change was introduced with the TV guide genre colourings as I suspected.
Although I'm really not impressed with this code, it shouldn't affect any plugin unless they replace the MP TV plugin like I think 4TR does.

I haven't tried 4TR for several years now but the way they used to replace the MP TV plugin seemed to me to be a bit of a hack. As I recall, they reused the MP TV plugin configuration as well. I could be wrong about that but that is the only way that I can imagine that this problem would occur.

If 4TR are doing this, I would have to say that I'm even less happy about that. Perhaps their devs could confirm?

mm