home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Support
General Support
MP hangs when scheduled recording starts.
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="mm1352000" data-source="post: 1178515" data-attributes="member: 82144"><p>After looking at the CEC Remote code, I see it has a WndProc(). Therefore it <em>should</em> be receiving the message from MP.</p><p></p><p>[USER=60104]@Sebastiii[/USER] </p><p>I think this change from you has broken plugin messaging:</p><p><a href="https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6" target="_blank">https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6</a></p><p></p><p>In particular, this line:</p><p><a href="https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6#diff-393471767838c7b3839e28d1fd5f7af7R2071" target="_blank">https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6#diff-393471767838c7b3839e28d1fd5f7af7R2071</a></p><p></p><p>WndProc() must be able to handle multiple messages simultaneously! Therefore you cannot use a single global variable _wndProcPluginExecuted for tracking whether WndProc() was executed.</p><p></p><p>For example (from the log file)...</p><p>1. WM_POWERBROADCAST message received. Handling starts.</p><p>[2016-03-13 11:09:10,753] [Log ] [MPMain ] [INFO ] - Main: WM_POWERBROADCAST (PBT_POWERSETTINGCHANGE)</p><p></p><p>2. WM_ACTIVATE message received. Handling starts.<strong> WM_POWERBROADCAST is still being handled!</strong></p><p>[2016-03-13 11:09:10,800] [Log ] [MPMain ] [DEBUG] - Main: WM_ACTIVATE (WA_ACTIVE)</p><p></p><p>3. WM_ACTIVATE message handling is completed. WndProcPlugin() is called, so _wndProcPluginExecuted is set true.</p><p></p><p>4. WM_POWERBROADCAST message handling is completed.</p><p>[2016-03-13 11:09:10,800] [Log ] [MPMain ] [INFO ] - Main: OnResumeSuspend - Done</p><p>[2016-03-13 11:09:10,815] [Log ] [MPMain ] [DEBUG] - Main: Providing input - suspended is false</p><p></p><p>WndProcPlugin() is called, <strong>but _wndProcPluginExecuted is already true from (3). BUG!</strong></p><p></p><p></p><p>To be clear: in this example, PluginManager.WndProc() will only be called for WM_ACTIVATE. After that, _wndProcPluginExecuted will be set true => blocks PluginManager.WndProc() for WM_POWERBROADCAST.</p><p></p><p>IMHO this change must be reverted or fixed urgently for 1.14. JIRA reopened...</p></blockquote><p></p>
[QUOTE="mm1352000, post: 1178515, member: 82144"] After looking at the CEC Remote code, I see it has a WndProc(). Therefore it [I]should[/I] be receiving the message from MP. [USER=60104]@Sebastiii[/USER] I think this change from you has broken plugin messaging: [URL]https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6[/URL] In particular, this line: [URL]https://github.com/MediaPortal/MediaPortal-1/commit/f45db6283c281e9edb25bc2e905a4e9d02ca64d6#diff-393471767838c7b3839e28d1fd5f7af7R2071[/URL] WndProc() must be able to handle multiple messages simultaneously! Therefore you cannot use a single global variable _wndProcPluginExecuted for tracking whether WndProc() was executed. For example (from the log file)... 1. WM_POWERBROADCAST message received. Handling starts. [2016-03-13 11:09:10,753] [Log ] [MPMain ] [INFO ] - Main: WM_POWERBROADCAST (PBT_POWERSETTINGCHANGE) 2. WM_ACTIVATE message received. Handling starts.[B] WM_POWERBROADCAST is still being handled![/B] [2016-03-13 11:09:10,800] [Log ] [MPMain ] [DEBUG] - Main: WM_ACTIVATE (WA_ACTIVE) 3. WM_ACTIVATE message handling is completed. WndProcPlugin() is called, so _wndProcPluginExecuted is set true. 4. WM_POWERBROADCAST message handling is completed. [2016-03-13 11:09:10,800] [Log ] [MPMain ] [INFO ] - Main: OnResumeSuspend - Done [2016-03-13 11:09:10,815] [Log ] [MPMain ] [DEBUG] - Main: Providing input - suspended is false WndProcPlugin() is called, [B]but _wndProcPluginExecuted is already true from (3). BUG![/B] To be clear: in this example, PluginManager.WndProc() will only be called for WM_ACTIVATE. After that, _wndProcPluginExecuted will be set true => blocks PluginManager.WndProc() for WM_POWERBROADCAST. IMHO this change must be reverted or fixed urgently for 1.14. JIRA reopened... [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Support
General Support
MP hangs when scheduled recording starts.
Contact us
RSS
Top
Bottom
